pf: remove unneeded double pointer to pf_scrub_ip(6)()
ClosedPublic
Actions

Authored by kp on Sat, Sep 7, 9:36 AM.

Tags

None

Referenced Files

	F95994445: D46593.id.diff
	Mon, Sep 23, 7:07 AM

	F95983874: D46593.id143089.diff
	Mon, Sep 23, 6:03 AM

	Unknown Object (File)
	Tue, Sep 17, 7:07 AM

	Unknown Object (File)
	Sat, Sep 14, 6:00 PM

	Unknown Object (File)
	Fri, Sep 13, 4:41 AM

	Unknown Object (File)
	Thu, Sep 12, 9:45 PM

	Unknown Object (File)
	Thu, Sep 12, 3:51 PM

	Unknown Object (File)
	Wed, Sep 11, 11:02 PM

Subscribers

vegeta_tuxpowered.net

zlei

Details

Reviewers

zlei

Group Reviewers

network
pfsense

Commits

rGb450a0f928d6: pf: remove unneeded double pointer to pf_scrub_ip(6)()

Summary

pf_scrub_ip() does not modify the given mbuf pointer. So don't
pass a pointer to a pointer to make the code in pf_test() clearer.
ok henning@

Obtained from: OpenBSD, bluhm <bluhm@openbsd.org>, aac78b59b9
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sat, Sep 7, 9:36 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 3 others. · View Herald TranscriptSat, Sep 7, 9:36 AM

kp requested review of this revision.Sat, Sep 7, 9:36 AM

Harbormaster completed remote builds in B59381: Diff 143089.Sat, Sep 7, 9:36 AM

kp added a parent revision: D46592: pf: handle ACK prioritization for v6.Sat, Sep 7, 9:36 AM

kp added a child revision: D46594: pf: exclude link local address from the dynamic interface address pool.

Looks good to me.

This revision is now accepted and ready to land.Sat, Sep 14, 8:09 AM

Closed by commit rGb450a0f928d6: pf: remove unneeded double pointer to pf_scrub_ip(6)() (authored by kp). · Explain WhyThu, Sep 19, 8:22 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGb450a0f928d6: pf: remove unneeded double pointer to pf_scrub_ip(6)().

Revision Contents
Changeset List

Path

Size

sys/

net/

pfvar.h

4 lines

netpfil/

pf/

pf.c

4 lines

pf_norm.c

6 lines

Diff 143490

View Options

sys/net/pfvar.h

View Options

sys/netpfil/pf/pf.c

View Options

pf: remove unneeded double pointer to pf_scrub_ip(6)()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 143490

sys/net/pfvar.h

sys/netpfil/pf/pf.c

sys/netpfil/pf/pf_norm.c

pf: remove unneeded double pointer to pf_scrub_ip(6)()
ClosedPublic
Actions

Revision Contents
Changeset List