Make it a little easier to detect if we've mistakenly passed a non-writable mbuf
to the crypto code.
This ought to make bugs like 280036 easier to find.
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential D46572
opencrypto: assert that mbufs are writable kp on Sep 7 2024, 9:33 AM. Authored by Tags None Referenced Files
Details
Diff Detail
Event Timeline
Comment Actions This seems ok to me, but please make sure to run the ipsec and ktls tests as well. (For the latter you need to set kern.ipc.tls.enable=1 and run tests/sys/kern/ktls_test.)
Comment Actions That's a good suggestion, because the 'ktls_test:ktls_transmit_aes128_cbc_1_0_sha1_control' test panics with this assertion. I'm sure I'm missing important details there, I'm not at all familiar with ktls. Comment Actions You might try doing this again after my other series lands. In this case though I think you'd need M_WRITABLE_EXTPG. |