Page MenuHomeFreeBSD
Differential D46582

pfctl: lex <=, >=, and != into a single token
ClosedPublic
Actions

Authored by kp on Sat, Sep 7, 9:34 AM.
Tags
None
Referenced Files
F95770009: D46582.diff
Sun, Sep 22, 1:44 PM
Unknown Object (File)
Sat, Sep 21, 2:50 AM
Unknown Object (File)
Tue, Sep 17, 10:33 PM
Unknown Object (File)
Tue, Sep 17, 3:01 AM
Unknown Object (File)
Mon, Sep 16, 1:10 PM
Unknown Object (File)
Mon, Sep 16, 9:56 AM
Unknown Object (File)
Sat, Sep 14, 9:05 PM
Unknown Object (File)
Thu, Sep 12, 2:55 AM
View All 17 Files
Subscribers
imp
zlei

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG80eb861dc2a7: pfctl: lex <=, >=, and != into a single token
Summary

lex <=, >=, and != into a single token for correctness and to reduce the
lookahead in the parser
ok henning otto

Obtained from: OpenBSD, deraadt <deraadt@openbsd.org>, e6e3ecf338
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Sat, Sep 7, 9:34 AM
Herald added a subscriber: imp. · View Herald TranscriptSat, Sep 7, 9:34 AM
kp requested review of this revision.Sat, Sep 7, 9:34 AM
Harbormaster completed remote builds in B59370: Diff 143078.Sat, Sep 7, 9:34 AM
kp added a parent revision: D46581: pf tests: ensure we correctly optimize { any, 192.0.2.3 }.Sat, Sep 7, 9:35 AM
kp added a child revision: D46583: pf: fix potential memory leaks in pf_create_state().
zlei added a subscriber: zlei.Sat, Sep 14, 7:50 AM

I like this change, from my limited parser knowledge :)

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Sep 16, 1:06 PM
Closed by commit rG80eb861dc2a7: pfctl: lex <=, >=, and != into a single token (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG80eb861dc2a7: pfctl: lex <=, >=, and != into a single token.

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
20 lines

Diff 143390

View Options

sbin/pfctl/parse.y

Loading...