This patch refactors the Performance Counter interrupt setup code to allow sharing the interrupt line between multiple drivers.
More specifically, Performance Counter interrupts are used by both hwpmc(4) and hwt(4)'s Intel Processor Trace backend.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
sys/x86/x86/local_apic.c | ||
---|---|---|
817 | Why do we need these braces? Why not provide pcint() services regardless of hwpmc/hwt? IMO it is more logical, and slight unconditional code addition does not matter for amd64. But we reduce the ifdef maze then. |
sys/x86/x86/local_apic.c | ||
---|---|---|
817 | Right, the initial version was a knee-jerk reaction, what you suggested makes sense. |
sys/x86/x86/local_apic.c | ||
---|---|---|
39 | Are both opts still needed? |