arm64: Make shareability attributes dynamic
ClosedPublic
Actions

Authored by andrew on Aug 21 2024, 12:15 PM.

Details

Reviewers

alc
kib
markj
manu

Group Reviewers

arm64

Commits

rGd52c31904218: arm64: Make shareability attributes dynamic

Summary

When LPA2 is enabled the shareability attribute in the page table are
replaces with output address bits. To support a larger physical address
space make this attribute dynamic so we only set it when appropriate.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Aug 21 2024, 12:15 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 21 2024, 12:15 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Aug 21 2024, 12:15 PM

andrew added a parent revision: D46393: arm64: Remove TCR_CACHE_ATTRS and TCR_SMP_ATTRS.

andrew added a child revision: D46395: arm64: Make L1_BLOCKS_SUPPORTED dynamic.

Harbormaster completed remote builds in B59122: Diff 142300.Aug 21 2024, 12:16 PM

markj added inline comments.Thu, Aug 22, 3:33 PM

sys/arm64/include/pte.h
114 ↗	(On Diff #142300)	Why not include `pmap_sh_attr` here?

andrew added inline comments.Thu, Aug 22, 5:31 PM

sys/arm64/include/pte.h
114 ↗	(On Diff #142300)	We can't because it's used in `locore.S`

kib added inline comments.Fri, Aug 23, 11:31 AM

sys/arm64/arm64/pmap.c
358	Again, should it be __read_mostly?

alc added inline comments.Fri, Aug 23, 4:43 PM

sys/arm64/include/pte.h
114 ↗	(On Diff #142300)	At this point, where ATTR_DEFAULT is simply ATTR_AF, I'm going to argue for its elimination. Instead, put ATTR_AF in its place. There are places where we construct the mapping with ATTR_DEFAULT, then later clear ATTR_AF. Instead, these could simply not set ATTR_AF in the first place, and only set it if the mapping is unmanaged.