Page MenuHomeFreeBSD

dev_pager: define free_page for mgt devices
ClosedPublic

Authored by dougm on Aug 21 2024, 2:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 5:30 PM
Unknown Object (File)
Oct 2 2024, 9:19 PM
Unknown Object (File)
Sep 29 2024, 8:45 PM
Unknown Object (File)
Sep 15 2024, 12:11 AM
Unknown Object (File)
Sep 15 2024, 12:11 AM
Unknown Object (File)
Sep 15 2024, 12:11 AM
Unknown Object (File)
Sep 15 2024, 12:11 AM
Unknown Object (File)
Sep 6 2024, 10:50 AM

Details

Summary

Callers of cdev_pager_free_page always have object->type == OBJT_MGTDEVICE. Define a function for them to call that skips the runtime type check.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Aug 21 2024, 2:07 AM
sys/vm/device_pager.c
264–265

I do not see much reason to keep this assert, both callees are asserting the same lock.

275

I suggest to keep the cdev_ name prefix. Like cdev_mgtdev_pager_free_page()

dougm marked 2 inline comments as done.

Accept all suggestions.

This revision is now accepted and ready to land.Aug 21 2024, 5:13 PM
This revision was automatically updated to reflect the committed changes.