Page MenuHomeFreeBSD
Differential D46163

sound: Add device status string to sndstat nvlist
ClosedPublic
Actions

Authored by christos on Jul 26 2024, 1:47 PM.
Tags
None
Referenced Files
F97877194: D46163.id141441.diff
Tue, Oct 1, 2:41 PM
Unknown Object (File)
Sat, Sep 28, 4:50 AM
Unknown Object (File)
Thu, Sep 26, 12:00 AM
Unknown Object (File)
Wed, Sep 18, 5:17 AM
Unknown Object (File)
Sun, Sep 15, 9:58 PM
Unknown Object (File)
Mon, Sep 9, 2:05 AM
Unknown Object (File)
Mon, Sep 9, 1:15 AM
Unknown Object (File)
Sun, Sep 8, 7:49 AM
View All 21 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG894edb7cb133: sound: Add device status string to sndstat nvlist
rG810530aa2648: sound: Add device status string to sndstat nvlist
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58860
Build 55747: arc lint + arc unit

Event Timeline

christos created this revision.Jul 26 2024, 1:47 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 26 2024, 1:47 PM
christos requested review of this revision.Jul 26 2024, 1:47 PM
Harbormaster completed remote builds in B58859: Diff 141441.Jul 26 2024, 1:47 PM
emaste added inline comments.Jul 26 2024, 2:18 PM
share/man/man4/sndstat.4
32

date should be bumped for the addition

174

can we clarify with the status means (what sort of status)

dev_submerge.ch added a comment.Jul 26 2024, 2:19 PM

Could we add this field to the test in D45901?

christos added a comment.Jul 26 2024, 2:20 PM
In D46163#1052024, @dev_submerge.ch wrote:

Could we add this field to the test in D45901?

Yes, I have updated this patch as well, just didn't push it here.

christos updated this revision to Diff 141442.Jul 26 2024, 2:44 PM
christos marked 2 inline comments as done.

Address Ed's comments.

Harbormaster completed remote builds in B58860: Diff 141442.Jul 26 2024, 2:44 PM
dev_submerge.ch accepted this revision.Jul 26 2024, 6:26 PM
This revision is now accepted and ready to land.Jul 26 2024, 6:26 PM
Closed by commit rG810530aa2648: sound: Add device status string to sndstat nvlist (authored by christos). · Explain WhyJul 27 2024, 11:57 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG810530aa2648: sound: Add device status string to sndstat nvlist.
christos added a commit: rG894edb7cb133: sound: Add device status string to sndstat nvlist.Jul 29 2024, 3:35 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
6 lines
sys/
dev/
sound/
pcm/
1 line
sys/
1 line

Diff 141442

View Options

share/man/man4/sndstat.4

Loading...
View Options

sys/dev/sound/pcm/sndstat.c

Loading...
View Options

sys/sys/sndstat.h

Loading...