sound: Do not cast return value of malloc(9)
AcceptedPublic
Actions

Authored by christos on Sun, Sep 29, 12:50 PM.

Details

Reviewers

Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59651
Build 56538: arc lint + arc unit

christos requested review of this revision.Sun, Sep 29, 12:50 PM

Looks good to me.

This revision is now accepted and ready to land.Sun, Sep 29, 2:31 PM

markj added inline comments.

sys/dev/sound/pci/hda/hdaa.c
3036	JFYI: we also have mallocarray(), which is nice when one of the parameters is untrusted. A naive multiplication can overflow and result in allocating less memory than expected, which can result in security vulnerabilities in the worst case. mallocarray() will panic in this case instead. I don't think it matters here, just thought I'd mention it.
sys/dev/sound/pci/spicds.c
147