Page MenuHomeFreeBSD
Differential D46844

sound: Do not cast return value of malloc(9)
ClosedPublic
Actions

Authored by christos on Sep 29 2024, 12:50 PM.
Tags
None
Referenced Files
F102912462: D46844.diff
Mon, Nov 18, 4:16 PM
Unknown Object (File)
Sat, Nov 16, 7:07 PM
Unknown Object (File)
Thu, Nov 14, 9:20 PM
Unknown Object (File)
Thu, Nov 14, 5:22 PM
Unknown Object (File)
Thu, Nov 14, 2:41 PM
Unknown Object (File)
Thu, Nov 14, 2:24 PM
Unknown Object (File)
Sun, Nov 10, 9:59 AM
Unknown Object (File)
Tue, Nov 5, 5:02 AM
View All 16 Files
Subscribers
imp
zlei

Details

Reviewers
markj
emaste
dev_submerge.ch
zlei
Commits
rG84f361c9e367: sound: Do not cast return value of malloc(9)
rG3cc01caa26e4: sound: Do not cast return value of malloc(9)
Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Sep 29 2024, 12:50 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 29 2024, 12:50 PM
christos requested review of this revision.Sep 29 2024, 12:50 PM
Harbormaster completed remote builds in B59651: Diff 143897.Sep 29 2024, 12:50 PM
zlei accepted this revision.Sep 29 2024, 2:31 PM
zlei added a subscriber: zlei.

Looks good to me.

This revision is now accepted and ready to land.Sep 29 2024, 2:31 PM
dev_submerge.ch accepted this revision.Sep 29 2024, 4:25 PM
markj accepted this revision.Sep 30 2024, 8:23 AM
markj added inline comments.
sys/dev/sound/pci/hda/hdaa.c
3036

JFYI: we also have mallocarray(), which is nice when one of the parameters is untrusted. A naive multiplication can overflow and result in allocating less memory than expected, which can result in security vulnerabilities in the worst case. mallocarray() will panic in this case instead.

I don't think it matters here, just thought I'd mention it.

sys/dev/sound/pci/spicds.c
147
emaste accepted this revision.Sep 30 2024, 1:39 PM
Closed by commit rG3cc01caa26e4: sound: Do not cast return value of malloc(9) (authored by christos). · Explain WhyOct 18 2024, 8:45 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG3cc01caa26e4: sound: Do not cast return value of malloc(9).
christos added a commit: rG84f361c9e367: sound: Do not cast return value of malloc(9).Sun, Oct 20, 11:22 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
fdt/
2 lines
pci/
hda/
20 lines
2 lines
2 lines
pcm/
6 lines
2 lines

Diff 145093

View Options

sys/dev/sound/fdt/audio_soc.c

Loading...
View Options

sys/dev/sound/pci/hda/hdaa.c

Loading...
View Options

sys/dev/sound/pci/maestro3.c

Loading...
View Options

sys/dev/sound/pci/spicds.c

Loading...
View Options

sys/dev/sound/pcm/dsp.c

Loading...
View Options

sys/dev/sound/pcm/sndstat.c

Loading...