sound: Do not check for NULL if sbuf is allocated with SBUF_AUTOEXTEND
AcceptedPublic
Actions

Authored by christos on Sun, Sep 29, 2:09 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59654
Build 56541: arc lint + arc unit

Event Timeline

christos created this revision.Sun, Sep 29, 2:09 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Sep 29, 2:09 PM

christos requested review of this revision.Sun, Sep 29, 2:09 PM

Harbormaster completed remote builds in B59654: Diff 143901.Sun, Sep 29, 2:09 PM

dev_submerge.ch accepted this revision.Sun, Sep 29, 4:43 PM

This revision is now accepted and ready to land.Sun, Sep 29, 4:43 PM

markj accepted this revision.Mon, Sep 30, 8:10 AM

Should we clarify this case in sbuf(9), either with the SBUF_AUTOEXTEND description or in the RETURN VALUES section for sbuf_new?

Across the tree there's a mix of checking for NULL with SBUF_AUTOEXTEND and not checking, sometimes both cases in the same file (sys/dev/acpica/acpi.c).

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

midi/

midi.c

6 lines

pcm/

sndstat.c

5 lines

Diff 143901

View Options

sys/dev/sound/midi/midi.c