ClosedPublic
Actions

Authored by kevans on Jun 21 2024, 4:59 PM.

Details

Reviewers

kib
markj

Group Reviewers

Klara

Commits

rG88276dfbf19e: include: ssp: fortify poll/ppoll from <poll.h>

Summary

For poll/ppoll we just need to bounds-check the poll array that we're
about to write out to.

Sponsored by: Stormshieled
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58366
Build 55254: arc lint + arc unit

Event Timeline

kevans created this revision.Jun 21 2024, 4:59 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 21 2024, 4:59 PM

kevans requested review of this revision.Jun 21 2024, 4:59 PM

Harbormaster completed remote builds in B58289: Diff 140081.Jun 21 2024, 4:59 PM

kevans added a parent revision: D45679: include: ssp: round out fortification of current set of headers.Jun 21 2024, 4:59 PM

kevans added a child revision: D45681: include: ssp: fortify <stdlib.h>.

markj added inline comments.Jun 24 2024, 4:54 PM

include/ssp/poll.h
3	Extra line here.
lib/libc/sys/ppoll.c
40–41	This line is too long.

markj accepted this revision as: markj.Jun 24 2024, 4:54 PM

This revision is now accepted and ready to land.Jun 24 2024, 4:54 PM

kevans marked 2 inline comments as done.Jun 26 2024, 7:11 PM

kevans added inline comments.

include/ssp/poll.h
3	Addressed here and all of the other headers since these were all copy/paste into each other.

Address review feedback

This revision now requires review to proceed.Jun 26 2024, 7:12 PM

Harbormaster completed remote builds in B58366: Diff 140280.Jun 26 2024, 7:12 PM

kib accepted this revision.Jun 27 2024, 3:14 PM

This revision is now accepted and ready to land.Jun 27 2024, 3:14 PM

Closed by commit rG88276dfbf19e: include: ssp: fortify poll/ppoll from <poll.h> (authored by kevans). · Explain WhyJul 13 2024, 5:23 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG88276dfbf19e: include: ssp: fortify poll/ppoll from <poll.h>.

Revision Contents
Changeset List

Path

Size

include/

ssp/

Makefile

2 lines

poll.h

62 lines

lib/

libc/

sys/

poll.c

5 lines

ppoll.c

8 lines

tests/

secure/

Makefile

1 line

	fortify_poll_test.c
	fortify_strings_test.c

fortify_stdio_test.c

fortify_string_test.c

fortify_strings_test.c

fortify_unistd_test.c

generate-fortify-tests.lua

34 lines

sys/

poll.h

4 lines

Diff 140280

View Options

include/ssp/Makefile

View Options

include/ssp/poll.h

View Options

lib/libc/sys/poll.c

View Options

lib/libc/sys/ppoll.c

View Options

lib/libc/tests/secure/Makefile

View Options

lib/libc/tests/secure/fortify_poll_test.c

View Options

lib/libc/tests/secure/fortify_stdio_test.c

View Options

lib/libc/tests/secure/fortify_string_test.c

View Options

lib/libc/tests/secure/fortify_strings_test.c

View Options

lib/libc/tests/secure/fortify_unistd_test.c

View Options

lib/libc/tests/secure/generate-fortify-tests.lua

View Options

include: ssp: fortify poll/ppoll from <poll.h>ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 140280

include/ssp/Makefile

include/ssp/poll.h

lib/libc/sys/poll.c

lib/libc/sys/ppoll.c

lib/libc/tests/secure/Makefile

lib/libc/tests/secure/fortify_poll_test.c

lib/libc/tests/secure/fortify_stdio_test.c

lib/libc/tests/secure/fortify_string_test.c

lib/libc/tests/secure/fortify_strings_test.c

lib/libc/tests/secure/fortify_unistd_test.c

lib/libc/tests/secure/generate-fortify-tests.lua

sys/sys/poll.h

include: ssp: fortify poll/ppoll from <poll.h>
ClosedPublic
Actions

Revision Contents
Changeset List