include: ssp: fortify <wchar.h>
ClosedPublic
Actions

Authored by kevans on Jun 21 2024, 4:59 PM.

Details

Reviewers

kib
markj

Group Reviewers

Klara

Commits

rGb53d7aa88fd5: include: ssp: fortify <wchar.h>

Summary

This includes all of the w*() equivalents to str*()/mem*() implemented
in more or less the same way. For these ones, we'll just use
header-only implementations from the start to stop further cluttering
the libc symbol table.

Sponsored by: Stormshield
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Jun 21 2024, 4:59 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 21 2024, 4:59 PM

kevans requested review of this revision.Jun 21 2024, 4:59 PM

Harbormaster completed remote builds in B58291: Diff 140083.Jun 21 2024, 4:59 PM

kevans added a parent revision: D45681: include: ssp: fortify <stdlib.h>.Jun 21 2024, 5:00 PM

kevans added a child revision: D45683: include: ssp: fortify <sys/random.h>.

markj added inline comments.Jul 2 2024, 2:23 PM

include/ssp/wchar.h
51	Do you need `__BEGIN_DECLS` for these inline functions?
59	Do you need to multiply `len` by `sizeof(wchar_t)` here? I think __ssp_overlap takes a bytecount.

markj added inline comments.Jul 2 2024, 2:32 PM

include/ssp/wchar.h
59	Oh, I guess that's ok, it uses pointer arithmetic. That's a bit subtle.

kevans marked 2 inline comments as done.Jul 9 2024, 7:53 PM

kevans added inline comments.

include/ssp/wchar.h
51	Not for the inlines, but `__ssp_redirect_raw_impl` also adds a couple of declarations with the symbol renaming bits before the function signature
59	Based on these and some other discussion, see D45940 for another take. I'll likely reorder that one to before this and just make these use the `__ssp_wchar_overlap()` helper from the start if that seems reasonable.