Page MenuHomeFreeBSD

pci: Only add special VF handling for direct children in bus methods
ClosedPublic

Authored by jhb on Jun 5 2024, 3:24 PM.
Tags
None
Referenced Files
F102666505: D45499.diff
Fri, Nov 15, 2:13 PM
Unknown Object (File)
Sep 18 2024, 8:13 PM
Unknown Object (File)
Sep 18 2024, 2:29 PM
Unknown Object (File)
Sep 18 2024, 4:34 AM
Unknown Object (File)
Sep 16 2024, 9:26 AM
Unknown Object (File)
Sep 14 2024, 9:27 PM
Unknown Object (File)
Sep 12 2024, 1:24 PM
Unknown Object (File)
Sep 10 2024, 1:50 AM
Subscribers
None

Details

Summary

For activate/deactivate resource, use a more standard check at the
start of the function since the addition of the PCI_IOV code made this
more complex. For the three recently added methods, just add the
typical check at the beginning that I missed.

This wasn't always fatal as if your system only had PCI device_t's as
children of PCI bus devices it would happen to work ok, but if you
have a non-PCI child device (e.g. an ATA channel) then dereferencing
ivars for non-direct-children could fault.

Reported by: Cirrus-CI (via emaste)
Fixes: 871b33ad65ba pci: Consistently use pci_vf_* for suballocated VF memory resources

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58068
Build 54956: arc lint + arc unit