ctl: Update some core data paths to be protocol agnostic
ClosedPublic
Actions

Authored by jhb on Apr 18 2024, 5:48 PM.

Details

Reviewers

imp
ken

Group Reviewers

cam

Commits

rGab4b83874a4e: ctl: Update some core data paths to be protocol agnostic

Summary

Add wrapper routines for invoking the be_move_done and io_continue callbacks in SCSI and NVMe I/O requests.

Use wrapper routines for access to shared fields between SCSI and NVMe I/O requests.

ctl_config_write_done is not fully updated since it resubmits SCSI commands via ctl_scsiio. This will be completed in a subsequent commit when ctl_nvmeio is added.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57505
Build 54393: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 18 2024, 5:48 PM

Herald added a reviewer: cam. · View Herald TranscriptApr 18 2024, 5:48 PM

jhb requested review of this revision.Apr 18 2024, 5:48 PM

Harbormaster completed remote builds in B57185: Diff 137324.Apr 18 2024, 5:48 PM

jhb added a child revision: D44847: ctl: Add assertions in SCSI-only paths.Apr 18 2024, 5:48 PM

jhb added a parent revision: D44719: ctl: Support NVMe requests in debug trace functions.Apr 18 2024, 5:49 PM

Update for CTL_IO_ASSERT macro

Harbormaster completed remote builds in B57505: Diff 137969.May 1 2024, 8:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2024, 12:16 AM

Closed by commit rGab4b83874a4e: ctl: Update some core data paths to be protocol agnostic (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGab4b83874a4e: ctl: Update some core data paths to be protocol agnostic.

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

ctl.c

225 lines

Diff 137969

View Options

ctl: Update some core data paths to be protocol agnosticClosedPublicActions