Paths

Table of Contentst

Differential D44709

nvmft: Add NVMeoF controller routines shared between kernel and userland
ClosedPublic
Actions

Authored by jhb on Apr 9 2024, 11:03 PM.

Details

Reviewers

imp

Commits

rG2f7b0de1de47: nvmft: Add NVMeoF controller routines shared between kernel and userland

Summary

This includes functions to validate NVMe Qualified Names, compute an
initial value of the CAP property, validate changes to the CC
property, and populate the Identify Controller data structure for an
I/O controller.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 9 2024, 11:03 PM

jhb created this revision.

Harbormaster completed remote builds in B57000: Diff 136805.Apr 9 2024, 11:03 PM

jhb added a parent revision: D44708: nvmf_tcp.h: Internal header shared between userspace and kernel.Apr 9 2024, 11:03 PM

jhb added a child revision: D44710: libnvmf: Add internal library to support NVMe over Fabrics.

imp accepted this revision.Apr 13 2024, 6:05 PM

imp added inline comments.

sys/dev/nvmf/controller/nvmft_subr.c
52	MAybe #ifdef EXTRA_CHECKS or some such? Here and below

This revision is now accepted and ready to land.Apr 13 2024, 6:05 PM

jhb marked an inline comment as done.Apr 16 2024, 6:00 PM

jhb added inline comments.

sys/dev/nvmf/controller/nvmft_subr.c
52	I went with `#ifdef STRICT_CHECKS`

Rename #if 0

This revision now requires review to proceed.Apr 16 2024, 8:44 PM

Harbormaster completed remote builds in B57132: Diff 137177.Apr 16 2024, 8:44 PM

Switch to SPDX-only license blocks for C files

Harbormaster completed remote builds in B57526: Diff 137992.May 1 2024, 10:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2024, 12:16 AM

Closed by commit rG2f7b0de1de47: nvmft: Add NVMeoF controller routines shared between kernel and userland (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG2f7b0de1de47: nvmft: Add NVMeoF controller routines shared between kernel and userland.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvmf/

controller/

nvmft_subr.h

47 lines

nvmft_subr.c

259 lines

Diff 138060

View Options

sys/dev/nvmf/controller/nvmft_subr.h