Page MenuHomeFreeBSD

nvmf.h: New header defining ioctls for NVMe over Fabrics
ClosedPublic

Authored by jhb on Apr 9 2024, 11:03 PM.
Tags
None
Referenced Files
F106090247: D44706.id137976.diff
Wed, Dec 25, 5:54 AM
Unknown Object (File)
Wed, Dec 18, 1:25 AM
Unknown Object (File)
Mon, Dec 16, 12:57 PM
Unknown Object (File)
Nov 22 2024, 9:05 PM
Unknown Object (File)
Nov 21 2024, 6:47 AM
Unknown Object (File)
Nov 17 2024, 10:39 PM
Unknown Object (File)
Nov 17 2024, 10:36 PM
Unknown Object (File)
Nov 17 2024, 10:22 PM
Subscribers

Details

Summary

This defines structures, ioctl commands, and related constants used
for both the Fabrics host and controller.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 9 2024, 11:03 PM

One nit... also applies to all of this series of reviews: consider omitting the license boilerplate.

sys/dev/nvme/nvme.h
47

won't line numbers go stale quickly?

This revision is now accepted and ready to land.Apr 13 2024, 5:53 PM
In D44706#1020670, @imp wrote:

One nit... also applies to all of this series of reviews: consider omitting the license boilerplate.

Hmm, are we ready to do that? I know we have some SPDX-only files in the tree and are kind of allowing it, but I wasn't sure we'd crossed the point to preferring that by default.

sys/dev/nvme/nvme.h
47

Not the line number, the constant 200 as the second argument to _IO*

In D44706#1021491, @jhb wrote:
In D44706#1020670, @imp wrote:

One nit... also applies to all of this series of reviews: consider omitting the license boilerplate.

Hmm, are we ready to do that? I know we have some SPDX-only files in the tree and are kind of allowing it, but I wasn't sure we'd crossed the point to preferring that by default.

hence my suggesting that you consider it: it's an option....

sys/dev/nvme/nvme.h
47

Oh! That's a note for reserved future use...

Add NVMF_DISCONNECT_HOST and NVMF_DISCONNECT_ALL ioctls for /dev/nvmf

This revision now requires review to proceed.May 1 2024, 8:58 PM

Add NVMF_DISCONNECT_HOST and NVMF_DISCONNECT_ALL ioctls for /dev/nvmf

Switch to SPDX-only license blocks for C files

Do we want to omit license blocks in manpages as well as C source? I've left them in the manpages for now.

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2024, 12:16 AM
This revision was automatically updated to reflect the committed changes.