Page MenuHomeFreeBSD
Differential D44757

sound: Update some LICENSE headers
ClosedPublic
Actions

Authored by christos on Apr 12 2024, 6:11 PM.
Tags
None
Referenced Files
F102032573: D44757.diff
Wed, Nov 6, 6:26 PM
Unknown Object (File)
Fri, Oct 18, 11:14 AM
Unknown Object (File)
Wed, Oct 16, 1:25 PM
Unknown Object (File)
Mon, Oct 14, 8:37 AM
Unknown Object (File)
Sat, Oct 12, 8:30 PM
Unknown Object (File)
Fri, Oct 11, 10:32 PM
Unknown Object (File)
Thu, Oct 10, 4:12 AM
Unknown Object (File)
Wed, Oct 9, 4:58 PM
View All 54 Files
Subscribers
imp

Details

Reviewers
markj
Commits
rG51abcd0c477a: sound: Update some LICENSE headers
rG4f854658c5d6: sound: Update some LICENSE headers
Summary

The following commits introduced substantial changes to pcm/dsp.c,
pcm/sndstat.c and pcm/sound.c.

9da3b645dbaaad724d524727d003fed7be05ff7c ("sound: Move
sndstat_prepare_pcm() to pcm/sndstat.c and remove
sndstat_entry->handler")
e8c0d15a64fadb4a330f2da7244becaac161bb70 ("sound: Get rid of snd_clone
and use DEVFS_CDEVPRIV(9)")

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57056
Build 53944: arc lint + arc unit

Event Timeline

christos created this revision.Apr 12 2024, 6:11 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 12 2024, 6:11 PM
christos requested review of this revision.Apr 12 2024, 6:11 PM
Harbormaster completed remote builds in B57056: Diff 136947.Apr 12 2024, 6:11 PM
markj added a comment.Apr 12 2024, 6:19 PM

The log message should say which commit(s) this is for.

sys/dev/sound/pcm/sndstat.c
12

The "All rights reserved" should come before the new lines.

christos edited the summary of this revision. (Show Details)Apr 12 2024, 6:28 PM
christos updated this revision to Diff 136948.Apr 12 2024, 6:29 PM
christos marked an inline comment as done.
christos edited the summary of this revision. (Show Details)

Address Mark's comments.

Harbormaster completed remote builds in B57057: Diff 136948.Apr 12 2024, 6:29 PM
markj accepted this revision.Apr 12 2024, 6:30 PM

Looks ok with one nit fixed.

sys/dev/sound/pcm/dsp.c
13

Don't include this blank line.

This revision is now accepted and ready to land.Apr 12 2024, 6:30 PM
Closed by commit rG4f854658c5d6: sound: Update some LICENSE headers (authored by christos). · Explain WhyApr 12 2024, 6:36 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG4f854658c5d6: sound: Update some LICENSE headers.
christos added a commit: rG51abcd0c477a: sound: Update some LICENSE headers.Apr 18 2024, 12:42 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
5 lines
5 lines
5 lines

Diff 136947

View Options

sys/dev/sound/pcm/dsp.c

Loading...
View Options

sys/dev/sound/pcm/sndstat.c

Loading...
View Options

sys/dev/sound/pcm/sound.c

Loading...