Page MenuHomeFreeBSD
Differential D49804

sound: Access softc through si_drv1 in dsp cdev methods
AcceptedPublic
Actions

Authored by christos on Sat, Apr 12, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 3:53 PM
Unknown Object (File)
Thu, Apr 17, 9:54 AM
Unknown Object (File)
Thu, Apr 17, 2:45 AM
Unknown Object (File)
Thu, Apr 17, 2:10 AM
Unknown Object (File)
Wed, Apr 16, 8:39 AM
Unknown Object (File)
Mon, Apr 14, 7:56 AM
Unknown Object (File)
Mon, Apr 14, 4:41 AM
Unknown Object (File)
Mon, Apr 14, 4:12 AM
Subscribers
imp

Details

Reviewers
markj
emaste
kib
dev_submerge.ch
Summary

No functional change, but is needed by a follow-up patch.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63480
Build 60364: arc lint + arc unit

Event Timeline

christos created this revision.Sat, Apr 12, 8:13 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Apr 12, 8:13 PM
christos requested review of this revision.Sat, Apr 12, 8:13 PM
Harbormaster completed remote builds in B63480: Diff 153587.Sat, Apr 12, 8:13 PM
christos added a child revision: D49805: sound: Create a dsp_close() helper function.Sat, Apr 12, 8:13 PM
christos added a child revision: D49216: sound: Implement /dev/dsp as a router device.Sat, Apr 12, 8:14 PM
christos removed a child revision: D49216: sound: Implement /dev/dsp as a router device.
markj added a comment.Sun, Apr 13, 4:05 PM

So should the priv->sc field be removed entirely?

christos added a comment.Mon, Apr 14, 2:15 PM
In D49804#1135648, @markj wrote:

So should the priv->sc field be removed entirely?

So, as I mention in the commit message, this is just part of a series of patches, and the last patch (at its current form) which is not yet submitted here, _does_ get rid of priv->sc eventually, however D49216 still needs it.

kib accepted this revision.Mon, Apr 14, 3:52 PM
This revision is now accepted and ready to land.Mon, Apr 14, 3:52 PM
markj accepted this revision.Mon, Apr 14, 7:11 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
24 lines

Diff 153587

View Options

sys/dev/sound/pcm/dsp.c

Loading...