Page MenuHomeFreeBSD
Differential D49805

sound: Create a dsp_close() helper function
AcceptedPublic
Actions

Authored by christos on Sat, Apr 12, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 2:57 PM
Unknown Object (File)
Thu, Apr 17, 1:41 PM
Unknown Object (File)
Thu, Apr 17, 9:53 AM
Unknown Object (File)
Thu, Apr 17, 2:45 AM
Unknown Object (File)
Thu, Apr 17, 2:10 AM
Unknown Object (File)
Wed, Apr 16, 8:31 AM
Unknown Object (File)
Sun, Apr 13, 5:52 PM
Unknown Object (File)
Sun, Apr 13, 5:14 AM
Subscribers
imp

Details

Reviewers
markj
emaste
kib
dev_submerge.ch
Summary

Needed by follow-up patch.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63481
Build 60365: arc lint + arc unit

Event Timeline

christos created this revision.Sat, Apr 12, 8:13 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Apr 12, 8:13 PM
christos requested review of this revision.Sat, Apr 12, 8:13 PM
Harbormaster completed remote builds in B63481: Diff 153588.Sat, Apr 12, 8:13 PM
christos added a parent revision: D49804: sound: Access softc through si_drv1 in dsp cdev methods.Sat, Apr 12, 8:13 PM
christos added a child revision: D49216: sound: Implement /dev/dsp as a router device.Sat, Apr 12, 8:14 PM
markj accepted this revision.Sun, Apr 13, 4:02 PM
This revision is now accepted and ready to land.Sun, Apr 13, 4:02 PM
kib added inline comments.Mon, Apr 14, 3:54 PM
sys/dev/sound/pcm/dsp.c
268

So where are these non-NULL checks in the new code?

christos added inline comments.Mon, Apr 14, 3:56 PM
sys/dev/sound/pcm/dsp.c
268

At the very beginning of dsp_close_chan().

kib added inline comments.Mon, Apr 14, 4:01 PM
sys/dev/sound/pcm/dsp.c
268

Are the values of priv->{rd,wr}ch stable? You are now checking for their non-NULL after priv->sc acquire.

christos added inline comments.Tue, Apr 15, 5:36 PM
sys/dev/sound/pcm/dsp.c
268

Primary (i.e., non-vchan) channels are destroyed during detach (see pcm_killchans()), and vchans in dsp_close() (see vchan_destroy()). So I think it's safe to leave the check as is. If we're detaching, we'll catch that a few lines below and bail-out anyway, and for vchans, well, we destroy them here only.

kib accepted this revision.Tue, Apr 15, 6:04 PM
christos marked 2 inline comments as done.Tue, Apr 15, 6:06 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
129 lines

Diff 153588

View Options

sys/dev/sound/pcm/dsp.c

Loading...