Page MenuHomeFreeBSD
Differential D43800

reboot: Disallow -k and -r, it doesn't make sense.
ClosedPublic
Actions

Authored by imp on Feb 9 2024, 5:11 AM.
Tags
None
Referenced Files
F102674670: D43800.diff
Fri, Nov 15, 5:03 PM
Unknown Object (File)
Fri, Nov 1, 2:18 AM
Unknown Object (File)
Mon, Oct 21, 1:18 AM
Unknown Object (File)
Mon, Oct 21, 1:18 AM
Unknown Object (File)
Mon, Oct 21, 1:18 AM
Unknown Object (File)
Mon, Oct 21, 1:18 AM
Unknown Object (File)
Mon, Oct 21, 1:17 AM
Unknown Object (File)
Fri, Oct 18, 7:32 PM
View All 56 Files
Subscribers
cy
grahamperrin

Details

Reviewers
kib
emaste
kevans
Commits
rGa78bc42bcc31: reboot: Disallow -k and -r, it doesn't make sense.
Summary

When we're re-rooting to a new /, there is no next kernel. Error out
rather than leaving a timebomb in /boot/nextboot.conf.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55883
Build 52772: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 9 2024, 5:11 AM
imp created this revision.
Herald added a subscriber: cy. · View Herald TranscriptFeb 9 2024, 5:11 AM
Harbormaster completed remote builds in B55874: Diff 134028.Feb 9 2024, 5:11 AM
imp added a child revision: D43801: reboot: convert flags to bools.Feb 9 2024, 5:12 AM
imp added reviewers: kib, emaste, kevans.Feb 9 2024, 5:14 AM
kib accepted this revision.Feb 9 2024, 6:31 AM
This revision is now accepted and ready to land.Feb 9 2024, 6:31 AM
emaste added inline comments.Feb 9 2024, 5:07 PM
sbin/reboot/reboot.c
119

period at the end of the errx here is inconsistent with the other errors

imp marked an inline comment as done.Feb 9 2024, 5:42 PM
imp added inline comments.
sbin/reboot/reboot.c
119

Ah, I was trying to be paranoid about that and missed one. thanks!

imp updated this revision to Diff 134046.Feb 9 2024, 5:42 PM
imp marked an inline comment as done.

remove period for consistency.

This revision now requires review to proceed.Feb 9 2024, 5:42 PM
Harbormaster completed remote builds in B55883: Diff 134046.Feb 9 2024, 5:42 PM
grahamperrin added a subscriber: grahamperrin.Feb 9 2024, 10:28 PM
imp updated this revision to Diff 134119.Feb 11 2024, 2:24 AM

rebase / refresh

Harbormaster completed remote builds in B55918: Diff 134119.Feb 11 2024, 2:24 AM
kevans accepted this revision.Feb 12 2024, 4:55 PM
This revision is now accepted and ready to land.Feb 12 2024, 4:55 PM
emaste accepted this revision.Feb 12 2024, 4:59 PM

oh also probably a semicolon instead of a comma like the "must reboot instead" above

Closed by commit rGa78bc42bcc31: reboot: Disallow -k and -r, it doesn't make sense. (authored by imp). · Explain WhyFeb 12 2024, 6:53 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGa78bc42bcc31: reboot: Disallow -k and -r, it doesn't make sense..

Revision Contents
Changeset List

PathSize
sbin/
reboot/
2 lines

Diff 134046

View Options

sbin/reboot/reboot.c

Loading...