Page MenuHomeFreeBSD

rescue: Update for changes for nextboot
ClosedPublic

Authored by imp on Feb 12 2024, 5:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 21, 12:57 AM
Unknown Object (File)
Mon, Oct 21, 12:57 AM
Unknown Object (File)
Mon, Oct 21, 12:57 AM
Unknown Object (File)
Fri, Oct 18, 7:14 PM
Unknown Object (File)
Fri, Oct 18, 8:06 AM
Unknown Object (File)
Oct 4 2024, 11:03 AM
Unknown Object (File)
Oct 4 2024, 12:52 AM
Unknown Object (File)
Sep 26 2024, 8:51 PM
Subscribers

Details

Summary

The nextboot.sh script no longer exists, so doesn't need to be fixed. We
also need a link to nextboot (since it's now free). However,

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55965
Build 52854: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 12 2024, 5:45 AM
imp created this revision.
This revision is now accepted and ready to land.Feb 12 2024, 8:20 AM

Something's missing from the commit msg; it ends with "However,"

Also commit message should have a fixes tag

Something's missing from the commit msg; it ends with "However,"

Yea. Got interrupted.

Also commit message should have a fixes tag

So this bug is 4 years old, and is in all supported branches. I'm worried it would be viewed as a passive aggressive dig at the original work, which I've had mixed feeling about since I've had to go in and fix a number of things with it that weren't caught sooner.

Also, this doesn't actually fix a bug :)

Oh, the "fixes" I was thinking of is the commit that stops installing nextboot.sh.
My comment instead should be "this should be combined with D43831"

Oh, the "fixes" I was thinking of is the commit that stops installing nextboot.sh.
My comment instead should be "this should be combined with D43831"

I'll just move it before that before D43831. I'd rather have the removal be as stand-alone as possible. rescue doesn't at all depend on what we install, so making this change can happen even if we were still installing nextboot.sh

So I'm folding this and D43831 before pushing.

merge reviews... note: I've updated commit message locally, but not in phab.

This revision now requires review to proceed.Feb 12 2024, 6:41 PM
This revision is now accepted and ready to land.Feb 12 2024, 6:55 PM