net80211: remove ieee80211_unref_node()

[bz]

Summary

ieee80211_unref_node() was only used in two error cases in
ieee80211_send_nulldata(). There we do not need to guard against
ni pointer reuse after decrementing the refcount of the ni as we
only update the stats and return.

Update the man page and remove the link for the now gone function.

Sponsored by: The FreeBSD Foundation
X-MFC: never

[adrian]

Oh I remember some stupid corner cases waaaay back that needed this for stupid reasons? because some (temp) nodes only had one reference at that point that shouldn't? or something with the bssnode handling continuing to be stupid?

I'm fine with this, just keep an eye out for weird panics on AP VAPs after this.

[bz]

In D42035#958789, @adrian wrote:

Oh I remember some stupid corner cases waaaay back that needed this for stupid reasons? because some (temp) nodes only had one reference at that point that shouldn't? or something with the bssnode handling continuing to be stupid?

I'm fine with this, just keep an eye out for weird panics on AP VAPs after this.

Ifyou look at the two callers they do: deref; update stats in vap; return; at that point the caller has no idea that the local *ni was blanked out, so there is no difference with this. Unless your AP VAP problems were solved already, they are not in this code base.

[bz]

Correct reviewers, docs is docs, and man is man

[bz]

Anyone from manpages around?

[emaste]

OK

[bz]

Committed as https://cgit.FreeBSD.org/src/commit/?id=1137943b1c5b225e30b82350ff7fb12c258ea90f

not sure why the auto-close didn't work.