Page MenuHomeFreeBSD

tcp: move HPTS/LRO flags out of inpcb to tcpcb
AbandonedPublic

Authored by glebius on Apr 19 2023, 5:30 PM.
Tags
None
Referenced Files
F102753951: D39698.id120672.diff
Sat, Nov 16, 5:37 PM
F102743871: D39698.diff
Sat, Nov 16, 3:02 PM
Unknown Object (File)
Oct 2 2024, 5:15 AM
Unknown Object (File)
Oct 2 2024, 4:43 AM
Unknown Object (File)
Oct 1 2024, 1:24 PM
Unknown Object (File)
Sep 29 2024, 5:04 PM
Unknown Object (File)
Sep 13 2024, 3:39 AM
Unknown Object (File)
Aug 19 2024, 2:22 AM
Subscribers

Details

Summary

These flags are TCP specific. While here, make also several LRO
internal functions to pass tcpcb pointer instead of inpcb one.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51039
Build 47930: arc lint + arc unit

Event Timeline

cc requested changes to this revision.Apr 20 2023, 10:46 AM
cc added a subscriber: cc.
cc added inline comments.
sys/netinet/tcp_var.h
844

I think I have commented before in a different patch review. This TF2_TCP_ACCOUNTING value should be 0x00001000, not 0x00010000. Please correct it in a separate patch, so that all the following defines can be in order.

This revision now requires changes to proceed.Apr 20 2023, 10:46 AM
sys/netinet/tcp_var.h
844

But on a second thought, I think I can submit a patch to simply correct it. :)

sys/netinet/tcp_var.h
844

I created https://reviews.freebsd.org/D39716 to correct this TF2_TCP_ACCOUNTING value.

Why if 0x10000 is not used would it matter?

In D39698#903847, @rrs wrote:

Why if 0x10000 is not used would it matter?

I think it's value should be 0x1000. So that future new defines can have more space available.

Not sure what is going on with this Phabricator page. Actually, this change is committed after my commit rG8aa2be695e0c from https://reviews.freebsd.org/D39716. The new TF2 defines in tcp_var.h are in order. Thanks for taking care of this.