Page MenuHomeFreeBSD
Differential D39716

Correct the value of macro TF2_TCP_ACCOUNTING.
ClosedPublic
Actions

Authored by cc on Apr 20 2023, 11:48 AM.
Tags
None
Referenced Files
F102745589: D39716.id120715.diff
Sat, Nov 16, 3:27 PM
F102744165: D39716.diff
Sat, Nov 16, 3:06 PM
Unknown Object (File)
Mon, Nov 4, 1:53 PM
Unknown Object (File)
Sat, Oct 26, 10:06 PM
Unknown Object (File)
Wed, Oct 23, 1:41 AM
Unknown Object (File)
Mon, Oct 21, 12:20 AM
Unknown Object (File)
Sep 30 2024, 1:05 PM
Unknown Object (File)
Sep 26 2024, 4:39 AM
View All 30 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
rscheff
tuexen
glebius
Group Reviewers
transport
Commits
rG8aa2be695e0c: Correct the value of macro TF2_TCP_ACCOUNTING.
Summary

Make sure the values are in order.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cc created this revision.Apr 20 2023, 11:48 AM
Herald added a reviewer: transport. · View Herald TranscriptApr 20 2023, 11:48 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
cc requested review of this revision.Apr 20 2023, 11:48 AM
Harbormaster completed remote builds in B51059: Diff 120715.Apr 20 2023, 11:48 AM
cc mentioned this in D39698: tcp: move HPTS/LRO flags out of inpcb to tcpcb.Apr 20 2023, 11:50 AM
glebius accepted this revision.Apr 20 2023, 5:22 PM

I'm fine with this change. If you commit it quickly, I will respin values in D39698. Alternatively the value can remain as is, just add explicit comments that bits 0x1000, 0x2000, 0x4000, 0x8000 are unused and available.

cc added a comment.Apr 21 2023, 10:55 AM
In D39716#904013, @glebius wrote:

I'm fine with this change. If you commit it quickly, I will respin values in D39698. Alternatively the value can remain as is, just add explicit comments that bits 0x1000, 0x2000, 0x4000, 0x8000 are unused and available.

That alternative idea sounds good to me. :)

tuexen accepted this revision.Apr 24 2023, 11:21 AM
This revision is now accepted and ready to land.Apr 24 2023, 11:21 AM
rscheff accepted this revision.Apr 24 2023, 9:15 PM
Closed by commit rG8aa2be695e0c: Correct the value of macro TF2_TCP_ACCOUNTING. (authored by cc). · Explain WhyApr 24 2023, 11:29 PM
This revision was automatically updated to reflect the committed changes.
cc added a commit: rG8aa2be695e0c: Correct the value of macro TF2_TCP_ACCOUNTING..

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines

Diff 120962

View Options

sys/netinet/tcp_var.h

Loading...