Page MenuHomeFreeBSD

tcp: purge the input queue from tcp_discardcb()
ClosedPublic

Authored by glebius on Apr 19 2023, 5:30 PM.
Tags
None
Referenced Files
F97144146: D39696.id121036.diff
Fri, Sep 27, 10:31 PM
Unknown Object (File)
Mon, Sep 23, 9:41 PM
Unknown Object (File)
Sun, Sep 22, 7:44 PM
Unknown Object (File)
Tue, Sep 17, 3:54 AM
Unknown Object (File)
Mon, Sep 16, 7:54 PM
Unknown Object (File)
Mon, Sep 16, 11:42 AM
Unknown Object (File)
Sat, Sep 14, 3:32 PM
Unknown Object (File)
Tue, Sep 10, 2:16 AM
Subscribers

Details

Summary

The purge was intentionally removed in a540cdca3183. My assumption
was that the stacks that use the input queue always call the
tcp_handle_orphaned_packets() in there tfb_tcp_fb_fini method.
However, rack will skip doing that if t_fb_ptr is NULL and there are
scenarios when it is NULL, e.g. close(2) on a socket (but some
special close(2)). Instead of working out all possible scenarios
let's put this safebelt back.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable