Page MenuHomeFreeBSD
Differential D39669

ee: Drop P_() macro used for pre-C89 compatibility.
ClosedPublic
Actions

Authored by jhb on Apr 18 2023, 6:52 PM.
Tags
None
Referenced Files
F101954648: D39669.diff
Tue, Nov 5, 6:45 PM
Unknown Object (File)
Oct 1 2024, 2:33 AM
Unknown Object (File)
Oct 1 2024, 2:30 AM
Unknown Object (File)
Oct 1 2024, 12:23 AM
Unknown Object (File)
Sep 29 2024, 12:28 PM
Unknown Object (File)
Sep 24 2024, 4:00 AM
Unknown Object (File)
Sep 22 2024, 7:50 PM
Unknown Object (File)
Sep 22 2024, 4:30 AM
View All 68 Files
Subscribers
imp

Details

Reviewers
emaste
Commits
rG87cc8c6be050: ee: Drop P_() macro used for pre-C89 compatibility.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Apr 18 2023, 6:52 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 18 2023, 6:52 PM
jhb requested review of this revision.Apr 18 2023, 6:52 PM
Harbormaster completed remote builds in B51014: Diff 120601.Apr 18 2023, 6:52 PM
jhb added a child revision: D39670: ee: Use C89 function definitions..Apr 18 2023, 6:52 PM
emaste added inline comments.Apr 18 2023, 7:02 PM
contrib/ee/ee.c
251–335

drop this maybe?

252

style(9) remove space between function names and (?

emaste accepted this revision.Apr 18 2023, 7:03 PM
This revision is now accepted and ready to land.Apr 18 2023, 7:03 PM
jhb added inline comments.Apr 18 2023, 7:47 PM
contrib/ee/ee.c
251–335

That I might do as a separate commit.

252

Ok

Closed by commit rG87cc8c6be050: ee: Drop P_() macro used for pre-C89 compatibility. (authored by jhb). · Explain WhyApr 18 2023, 7:54 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG87cc8c6be050: ee: Drop P_() macro used for pre-C89 compatibility..
imp added a comment.Apr 18 2023, 11:17 PM

Love it. Didn't get a chance to hit 'accept'

Revision Contents
Changeset List

PathSize
contrib/
ee/
182 lines

Diff 120606

View Options

contrib/ee/ee.c

Loading...