Differential D39524

ee: Silence -Wdeprecated-non-prototype warnings.
AbandonedPublic
Actions

Authored by jhb on Apr 12 2023, 3:33 PM.

Tags

None

Referenced Files

	F97544643: D39524.diff
	Mon, Sep 30, 12:14 AM

	Unknown Object (File)
	Sun, Sep 29, 2:28 AM

	Unknown Object (File)
	Sat, Sep 28, 8:52 PM

	Unknown Object (File)
	Fri, Sep 27, 9:41 AM

	Unknown Object (File)
	Thu, Sep 26, 12:49 PM

	Unknown Object (File)
	Wed, Sep 25, 1:54 PM

	Unknown Object (File)
	Mon, Sep 23, 9:47 PM

	Unknown Object (File)
	Mon, Sep 23, 6:46 PM

View All 41 Files

Subscribers

Details

Reviewers

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50855
Build 47746: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 12 2023, 3:33 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 12 2023, 3:33 PM

jhb requested review of this revision.Apr 12 2023, 3:33 PM

Harbormaster completed remote builds in B50855: Diff 120203.Apr 12 2023, 3:33 PM

jhb added a parent revision: D39523: ipf: Use C89 function definitions..Apr 12 2023, 3:33 PM

jhb added a child revision: D39525: less: Silence -Wdeprecated-non-prototype warnings..

Does ee have an upstream? Perhaps we should move the source out of contrib/ and update it?

I kind of guessed ee might have an upstream still which is why I treated it as sendmail. I'm not really sure if it has a viable upstream though.

I did a little searching, and the original upstream site for ee is defunct. There are a couple of ee derivatives on GitHub and they all seem to start with the source out of FreeBSD. I'm fine with this change, but I think it's also fine to just de-vendor ee src.

Fine with me. Perhaps note in the commit message that ee has no active upstream (and if someone is so inclined they could c89ify it).

This revision is now accepted and ready to land.Apr 13 2023, 2:03 PM

Fixed the warnings instead in D39670.

Revision Contents
Changeset List

Path

Size

usr.bin/

ee/

2 lines

Diff 120203

usr.bin/ee/Makefile

Loading...