Differential D39521

rpc.rstatd/rwalld: Use more accurate function pointer types.
ClosedPublic
Actions

Authored by jhb on Apr 12 2023, 3:32 PM.

Tags

None

Referenced Files

	F101959760: D39521.diff
	Tue, Nov 5, 7:57 PM

	F101877936: D39521.id120587.diff
	Tue, Nov 5, 2:12 AM

	Unknown Object (File)
	Thu, Oct 31, 4:42 AM

	Unknown Object (File)
	Thu, Oct 31, 4:42 AM

	Unknown Object (File)
	Thu, Oct 31, 4:31 AM

	Unknown Object (File)
	Thu, Oct 17, 10:29 AM

	Unknown Object (File)
	Tue, Oct 15, 8:59 PM

	Unknown Object (File)
	Mon, Oct 14, 7:57 PM

View All 77 Files

Subscribers

Details

Reviewers

emaste
rmacklem
zlei

Commits

rGe4253ae822ec: rpc.rstatd/rwalld: Use more accurate function pointer types.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 12 2023, 3:32 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 12 2023, 3:32 PM

jhb requested review of this revision.Apr 12 2023, 3:32 PM

Harbormaster completed remote builds in B50852: Diff 120200.Apr 12 2023, 3:32 PM

jhb added a parent revision: D39520: bootpd: Use C89 function definitions..Apr 12 2023, 3:32 PM

jhb added a child revision: D39522: rbootd: Remove an unnecessary (and incomplete) function prototype..

jhb added a reviewer: rmacklem.Apr 12 2023, 6:59 PM

Looks good to me.

This revision is now accepted and ready to land.Apr 13 2023, 1:42 PM

Looks ok to me. Just fyi, using xdrproc_t outside the kernel is
always a bit sketchy, since the functions have variable
numbers of arguments and the typedef is a non-typedef.

Closed by commit rGe4253ae822ec: rpc.rstatd/rwalld: Use more accurate function pointer types. (authored by jhb). · Explain WhyApr 18 2023, 6:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe4253ae822ec: rpc.rstatd/rwalld: Use more accurate function pointer types..

Revision Contents
Changeset List

Path

Size

libexec/

rpc.rstatd/

33 lines

rpc.rwalld/

19 lines

Diff 120587

libexec/rpc.rstatd/rstat_proc.c

Loading...

libexec/rpc.rwalld/rwalld.c

Loading...