Page MenuHomeFreeBSD

bootpd: Use C89 function definitions.
ClosedPublic

Authored by jhb on Apr 12 2023, 3:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 16, 12:12 PM
Unknown Object (File)
Tue, Oct 15, 8:57 PM
Unknown Object (File)
Mon, Oct 14, 2:23 AM
Unknown Object (File)
Fri, Oct 11, 1:30 PM
Unknown Object (File)
Thu, Oct 10, 1:29 AM
Unknown Object (File)
Oct 5 2024, 7:28 PM
Unknown Object (File)
Oct 3 2024, 10:51 PM
Unknown Object (File)
Oct 2 2024, 3:32 AM
Subscribers

Details

Summary

Trim a few duplicate (but incomplete) function prototypes as well.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 12 2023, 3:32 PM
emaste added inline comments.
libexec/bootpd/dovend.c
39

perhaps we can change these to uint8_t in a subsequent commit?

libexec/bootpd/report.c
38

this seems kind of odd (unrelated to your work)

This revision is now accepted and ready to land.Apr 12 2023, 3:58 PM
libexec/bootpd/dovend.c
39

This entire codebase is in a different style from CMU. I tried to just focus on fixing the function definitions and leaving the rest alone.

libexec/bootpd/report.c
38

There's a lot of oddness in this code. :/

This revision was automatically updated to reflect the committed changes.