cron: Use C89 function definitions.
ClosedPublic
Actions

usr.sbin/cron/lib/entry.c
521–525	I've struggled with what to do with these kinds of comments when updating K&R->C89, but I think they don't add much value so am fine with them going.

jhb added inline comments.Apr 12 2023, 7:01 PM

usr.sbin/cron/lib/entry.c
521–525	Yes, I mostly just lost the comments in the changes in this series.

Looks good to me.

This revision is now accepted and ready to land.Apr 13 2023, 1:21 PM

Closed by commit rGe93f27e3aeb7: cron: Use C89 function definitions. (authored by jhb). · Explain WhyApr 18 2023, 6:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe93f27e3aeb7: cron: Use C89 function definitions..

Revision Contents
Changeset List

Path

Size

usr.sbin/

cron/

17 lines

25 lines

8 lines

6 lines

8 lines

12 lines

crontab/

crontab.c

22 lines

lib/

entry.c

37 lines

env.c

20 lines

misc.c

56 lines

Diff 120208

View Options

usr.sbin/cron/cron/cron.c

View Options

usr.sbin/cron/cron/database.c

View Options

usr.sbin/cron/cron/do_command.c

View Options

usr.sbin/cron/cron/job.c

View Options

usr.sbin/cron/cron/popen.c

View Options

usr.sbin/cron/cron/user.c

View Options

usr.sbin/cron/crontab/crontab.c

View Options

usr.sbin/cron/lib/entry.c

View Options

usr.sbin/cron/lib/env.c

View Options

cron: Use C89 function definitions.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 120208

usr.sbin/cron/cron/cron.c

usr.sbin/cron/cron/database.c

usr.sbin/cron/cron/do_command.c

usr.sbin/cron/cron/job.c

usr.sbin/cron/cron/popen.c

usr.sbin/cron/cron/user.c

usr.sbin/cron/crontab/crontab.c

usr.sbin/cron/lib/entry.c

usr.sbin/cron/lib/env.c

usr.sbin/cron/lib/misc.c

cron: Use C89 function definitions.
ClosedPublic
Actions

Revision Contents
Changeset List