Page MenuHomeFreeBSD

libmd: export and document *Fd/*FdChunk interfaces
ClosedPublic

Authored by kevans on Mar 9 2022, 3:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 30, 5:03 AM
Unknown Object (File)
Thu, Sep 19, 9:27 AM
Unknown Object (File)
Wed, Sep 11, 9:44 AM
Unknown Object (File)
Mon, Sep 9, 9:39 AM
Unknown Object (File)
Sep 3 2024, 10:56 PM
Unknown Object (File)
Sep 3 2024, 6:36 PM
Unknown Object (File)
Aug 24 2024, 1:54 PM
Unknown Object (File)
Aug 18 2024, 11:56 AM

Details

Summary

Fixes: de13c2427d6c ("libmd: introduce functions that operate on an fd")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans requested review of this revision.Mar 9 2022, 3:35 AM

I think you should add the "nearly" qualifier to identical, as saying they're identical and then mentioning an exception seems contradictory to me.

Otherwise, the syntax of the mdoc looks fine, can't speak for the code.

"...are identical, except..." is fine. If it weren't for the exception they would be identical, not nearly identical.

But if we really want to avoid the phrase something like "perform the same function as" or "are equivalent to" would do.

bcr added a subscriber: bcr.

Manpage looks good. Thanks!

fuz added a subscriber: fuz.

LGTM and exp-ran fine in PR 280784.

This revision is now accepted and ready to land.Sun, Sep 29, 11:14 PM