libmd: symbol versioning
ClosedPublic
Actions

Authored by kevans on Mar 9 2022, 3:35 AM.

Details

Reviewers

andrew
jrtc27
emaste
allanjude
fuz

Commits

rGe25527f75f73: libmd: symbol versioning

Summary

The primary benefit sought is exporting _libmd_* symbols in a private
namespace, and avoiding export of some other implementation details that
are shared amongst TUs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Mar 9 2022, 3:35 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 9 2022, 3:35 AM

kevans requested review of this revision.Mar 9 2022, 3:35 AM

Harbormaster completed remote builds in B44713: Diff 103665.Mar 9 2022, 3:35 AM

kevans added a parent revision: D34498: libmd: stop exporting _block symbols.Mar 9 2022, 3:35 AM

kevans added a child revision: D34500: libmd: split tests out into the test infrastructure.

fuz mentioned this in D45444: lib/libmd: rework and accelerate SHA1 implementation.Jun 17 2024, 8:44 AM

Could you please remove these _version symbols? They are not supposed to be used by consumers and should be made static or commented out in the source files.