These are needed across compilation units so we can keep the _libmd_
prefixing bits (though I suspect we're not likely to collide), but we
don't need to be exporting the unprefixed versions of these; it's an
implementation detail.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
These should also be removed from <sha.h>. This change will make D45444 easier as I don't have to stick to the prototype imposed by the old code.
| lib/libmd/sha1c.c | ||
|---|---|---|
| 499–500 | Do we also still need the _version symbols? They seem to be specific to SSLeay's implementation and are probably not needed anymore. | |
| lib/libmd/sha1c.c | ||
|---|---|---|
| 499–500 | I am not aware of any consumers of it. If you do remove it, also remove RMD160_version | |
Comment Actions
So we have no old binaries with the *_block symbols to resolve? I'm skeptical of that notion.
Comment Actions
What about the _Transform symbols? These also do not seem to be declared in the header files.
Comment Actions
An exp-run has been requested to see if we can safely remove the symbols: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280784
Comment Actions
Note that the exp-run contains a change set to remove the _version symbols, which should also be removed on commit.