Differential D49938

vm_object: use iterator in populate()
ClosedPublic
Actions

Authored by dougm on Mon, Apr 21, 3:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 25, 1:04 PM

	Unknown Object (File)
	Fri, Apr 25, 12:47 PM

	Unknown Object (File)
	Fri, Apr 25, 11:52 AM

	Unknown Object (File)
	Fri, Apr 25, 11:24 AM

	Unknown Object (File)
	Fri, Apr 25, 5:44 AM

	Unknown Object (File)
	Fri, Apr 25, 4:04 AM

	Unknown Object (File)
	Fri, Apr 25, 1:05 AM

	Unknown Object (File)
	Wed, Apr 23, 5:30 AM

View All 16 Files

Subscribers

Details

Reviewers

kib
alc

Commits

rGc802dd74bbcf: vm_object: use iterator in populate()

Summary

Use an iterator instead of tailq pointers in vm_object_populate().

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm requested review of this revision.Mon, Apr 21, 3:23 AM

dougm created this revision.

dougm added inline comments.Mon, Apr 21, 3:25 AM

sys/vm/vm_object.c
2156	I can't use VM_RADIX_FOREACH because when page[start] is NULL, the loop should end but VM_RADIX_FORALL would just start with the first page > start. I can't use VM_RADIX_FORALL because the original code can skip gaps of null pages, and FORALL cannot.

kib added inline comments.Mon, Apr 21, 2:05 PM

sys/vm/vm_object.c
2156	Perhaps add this text to the commit message, if not as a comment into the code.

Use the same iterator for grabbing and for unbusying. Use VM_RADIX_FORALL with an upper bound.

alc added inline comments.Thu, Apr 24, 8:15 PM

sys/vm/vm_object.c
2155–2156

dougm updated this revision to Diff 154241.Thu, Apr 24, 8:23 PM

kib accepted this revision.Thu, Apr 24, 11:37 PM

This revision is now accepted and ready to land.Thu, Apr 24, 11:37 PM

Closed by commit rGc802dd74bbcf: vm_object: use iterator in populate() (authored by dougm). · Explain WhyFri, Apr 25, 12:10 AM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rGc802dd74bbcf: vm_object: use iterator in populate().

Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 25, 12:10 AM

Revision Contents
Changeset List

Path

Size

sys/

vm/

11 lines

Diff 154241

sys/vm/vm_object.c

Loading...