Page MenuHomeFreeBSD
Differential D49790

kyua: Switch from std::auto_ptr<> to std::unique_ptr<>
Needs ReviewPublic
Actions

Authored by jhb on Fri, Apr 11, 6:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 10:26 AM
Unknown Object (File)
Thu, Apr 17, 2:45 AM
Unknown Object (File)
Thu, Apr 17, 2:10 AM
Unknown Object (File)
Thu, Apr 17, 12:13 AM
Unknown Object (File)
Tue, Apr 15, 11:48 AM
Unknown Object (File)
Sun, Apr 13, 3:05 AM
Unknown Object (File)
Sat, Apr 12, 11:22 PM
Unknown Object (File)
Sat, Apr 12, 4:14 PM
Subscribers
imp
ngie

Details

Reviewers
igoro
asomers
emaste
Summary

A few places were assigning auto_ptr<>s depending on the ownership
handoff. These now use an explicit std::move() as required by
unique_ptr<>.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63468
Build 60352: arc lint + arc unit

Event Timeline

jhb created this revision.Fri, Apr 11, 6:00 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 11, 6:00 PM
jhb requested review of this revision.Fri, Apr 11, 6:00 PM
Harbormaster completed remote builds in B63468: Diff 153539.Fri, Apr 11, 6:00 PM
jhb added a parent revision: D49789: atf: Switch from std::auto_ptr<> to std::unique_ptr<>.Fri, Apr 11, 6:00 PM
jhb added a comment.Fri, Apr 11, 6:03 PM

A test VM is most of the way through a full kyua test run with this stack of changes applied and seems to be running fine.

Most of this change was mechanical (sed -e 's/auto_ptr/unique_ptr/') with a few places adjusted to use std::move() to fix compile errors.

emaste added a comment.Wed, Apr 16, 12:02 PM

Please make sure this also makes it into https://github.com/freebsd/kyua/pulls

jhb added a comment.Wed, Apr 16, 2:06 PM

Upstream PR: https://github.com/freebsd/kyua/pull/264

emaste added a subscriber: ngie.Wed, Apr 16, 2:06 PM

Revision Contents
Changeset List

PathSize
contrib/
kyua/
cli/
2 lines
2 lines
2 lines
4 lines
engine/
2 lines
4 lines
model/
2 lines
8 lines
2 lines
os/
freebsd/
utils/
4 lines
utils/
4 lines
cmdline/
2 lines
config/
2 lines
18 lines
2 lines
2 lines
format/
2 lines
fs/
2 lines
logging/
2 lines
process/
14 lines
26 lines
8 lines
44 lines
4 lines
4 lines
8 lines
8 lines
2 lines
2 lines
8 lines
2 lines
signals/
18 lines
4 lines
4 lines
2 lines
2 lines
4 lines
2 lines
4 lines
6 lines
usr.bin/
kyua/
3 lines

Diff 153539

View Options

contrib/kyua/cli/cmd_report.cpp

Loading...
View Options

contrib/kyua/cli/cmd_report_junit.cpp

Loading...
View Options

contrib/kyua/cli/common.hpp

Loading...
View Options

contrib/kyua/cli/main.cpp

Loading...
View Options

contrib/kyua/engine/config.cpp

Loading...
View Options

contrib/kyua/engine/scheduler.cpp

Loading...
View Options

contrib/kyua/model/metadata.hpp

Loading...
View Options

contrib/kyua/model/metadata.cpp

Loading...
View Options

contrib/kyua/model/test_program.hpp

Loading...
View Options

contrib/kyua/os/freebsd/utils/jail.cpp

Loading...
View Options

contrib/kyua/utils/auto_array.hpp

Loading...
View Options

contrib/kyua/utils/cmdline/commands_map.hpp

Loading...
View Options

contrib/kyua/utils/config/lua_module_test.cpp

Loading...
View Options

contrib/kyua/utils/config/nodes.cpp

Loading...
View Options

contrib/kyua/utils/config/parser.hpp

Loading...
View Options

contrib/kyua/utils/config/tree_test.cpp

Loading...
View Options

contrib/kyua/utils/format/formatter.cpp

Loading...
View Options

contrib/kyua/utils/fs/directory.cpp

Loading...
View Options

contrib/kyua/utils/logging/operations.cpp

Loading...
View Options

contrib/kyua/utils/process/child.hpp

Loading...
View Options

contrib/kyua/utils/process/child.cpp

Loading...
View Options

contrib/kyua/utils/process/child.ipp

Loading...
View Options

contrib/kyua/utils/process/child_test.cpp

Loading...
View Options

contrib/kyua/utils/process/deadline_killer_test.cpp

Loading...
View Options

contrib/kyua/utils/process/executor.hpp

Loading...
View Options

contrib/kyua/utils/process/executor.cpp

Loading...
View Options

contrib/kyua/utils/process/executor.ipp

Loading...
View Options

contrib/kyua/utils/process/fdstream.hpp

Loading...
View Options

contrib/kyua/utils/process/isolation_test.cpp

Loading...
View Options

contrib/kyua/utils/process/operations_test.cpp

Loading...
View Options

contrib/kyua/utils/process/systembuf.hpp

Loading...
View Options

contrib/kyua/utils/signals/interrupts.cpp

Loading...
View Options

contrib/kyua/utils/signals/interrupts_test.cpp

Loading...
View Options

contrib/kyua/utils/signals/misc_test.cpp

Loading...
View Options

contrib/kyua/utils/signals/programmer.hpp

Loading...
View Options

contrib/kyua/utils/signals/timer.hpp

Loading...
View Options

contrib/kyua/utils/signals/timer.cpp

Loading...
View Options

contrib/kyua/utils/stream.hpp

Loading...
View Options

contrib/kyua/utils/stream.cpp

Loading...
View Options

contrib/kyua/utils/stream_test.cpp

Loading...
View Options

usr.bin/kyua/Makefile

Loading...