Page MenuHomeFreeBSD
Differential D49789

atf: Switch from std::auto_ptr<> to std::unique_ptr<>
ClosedPublic
Actions

Authored by jhb on Fri, Apr 11, 6:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 2:45 AM
Unknown Object (File)
Thu, Apr 17, 2:10 AM
Unknown Object (File)
Thu, Apr 17, 12:02 AM
Unknown Object (File)
Wed, Apr 16, 3:10 PM
Unknown Object (File)
Tue, Apr 15, 2:06 PM
Unknown Object (File)
Tue, Apr 15, 1:02 AM
Unknown Object (File)
Mon, Apr 14, 9:09 AM
Unknown Object (File)
Sun, Apr 13, 2:14 PM
View All 12 Files
Subscribers
bdrewery
imp

Details

Reviewers
igoro
asomers
emaste
Commits
rG5e6befdaca51: atf: Switch from std::auto_ptr<> to std::unique_ptr<>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Fri, Apr 11, 6:00 PM
Herald added subscribers: imp, bdrewery. · View Herald TranscriptFri, Apr 11, 6:00 PM
jhb requested review of this revision.Fri, Apr 11, 6:00 PM
Harbormaster completed remote builds in B63467: Diff 153538.Fri, Apr 11, 6:00 PM
jhb added a parent revision: D49788: lutok: Switch from std::auto_ptr<> to std::unique_ptr<>.Fri, Apr 11, 6:00 PM
jhb added a child revision: D49790: kyua: Switch from std::auto_ptr<> to std::unique_ptr<>.
emaste accepted this revision.Wed, Apr 16, 12:00 PM

Please make sure this also makes it into https://github.com/freebsd/atf/

This revision is now accepted and ready to land.Wed, Apr 16, 12:00 PM
jhb added a comment.Wed, Apr 16, 1:49 PM

Upstream has apparently fixed this differently using shared_ptr (not sure why, that seems wasteful and inefficient given there weren't any pointer assignments).

emaste added a comment.Wed, Apr 16, 1:59 PM

Upstream has apparently fixed this differently using shared_ptr

Huh, the only results for shared_ptr I see upstream are in NEWS claiming

Replace auto_ptr with std::shared_ptr (fixes modern C++ compliance).

But it's actually unique_ptr as in your review, from https://github.com/freebsd/atf/commit/f053ab687f6e27aa264f599ecbfc5ef27ad4e2d3
Pull request to update NEWS submitted: https://github.com/freebsd/atf/pull/103

jhb added a comment.Wed, Apr 16, 2:00 PM

Hah, cute. Ok then, that means I can still merge this and it will just fall out when doing our next vendor import.

Closed by commit rG5e6befdaca51: atf: Switch from std::auto_ptr<> to std::unique_ptr<> (authored by jhb). · Explain WhyWed, Apr 16, 2:12 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG5e6befdaca51: atf: Switch from std::auto_ptr<> to std::unique_ptr<>.

Revision Contents
Changeset List

PathSize
contrib/
atf/
atf-c++/
4 lines
4 lines
22 lines
detail/
8 lines
atf-sh/
8 lines
lib/
atf/
3 lines
libatf-c++/
3 lines
libexec/
atf/
atf-check/
4 lines
atf-sh/
3 lines
share/
mk/
2 lines

Diff 153728

View Options

contrib/atf/atf-c++/check.hpp

Loading...
View Options

contrib/atf/atf-c++/check.cpp

Loading...
View Options

contrib/atf/atf-c++/check_test.cpp

Loading...
View Options

contrib/atf/atf-c++/detail/process_test.cpp

Loading...
View Options

contrib/atf/atf-sh/atf-check.cpp

Loading...
View Options

lib/atf/Makefile.inc

Loading...
View Options

lib/atf/libatf-c++/Makefile

Loading...
View Options

libexec/atf/atf-check/Makefile

Loading...
View Options

libexec/atf/atf-sh/Makefile

Loading...
View Options

share/mk/atf.test.mk

Loading...