lutok: Switch from std::auto_ptr<> to std::unique_ptr<>

[emaste]

Push it to https://github.com/freebsd/lutok and bring in via contrib?

[igoro]

I remember ngie@ agreed in some past cases to go directly to the src while the expected vendor path could go in parallel at its own pace. The vendor branch seems to be non-updated since its import back in 2020, so the vendor path may face obstacles and could take time. I mention this just in case if there is a need to hit src sooner, so that an exception agreement could be considered.

[emaste]

In D49788#1136553, @igoro wrote:

I remember ngie@ agreed in some past cases to go directly to the src while the expected vendor path could go in parallel at its own pace. The vendor branch seems to be non-updated since its import back in 2020, so the vendor path may face obstacles and could take time. I mention this just in case if there is a need to hit src sooner, so that an exception agreement could be considered.

OK, no objection to bringing it into src directly as long as it also makes it into upstream. Now that upstream is in the FreeBSD GitHub org there shouldn't be a large barrier to getting the change merged there.

[jhb]

Upstream already has this change: https://github.com/freebsd/lutok/commit/bd5904144c9778a07685f3e4efa6ef011a5480ec

I could rework the log commit to claim this is obtained from that instead perhaps? I wasn't really planning on dealing with doing an import.

[emaste]

I could rework the log commit to claim this is obtained from that instead perhaps? I wasn't really planning on dealing with doing an import.

That's fine with me, in that case IMO just note that the same change exists upstream. Someone™ will/should eventually do a vendor update.