fusefs tests: Use memcpy to work around a -Wstrlcpy-strlcast-size warning
ClosedPublic
Actions

Authored by jhb on Fri, Apr 11, 5:57 PM.

Details

Reviewers

Commits

rGfaae895fec65: fusefs tests: Use memcpy to work around a -Wstrlcpy-strlcast-size warning

Summary

tests/sys/fs/fusefs/xattr.cc:572:50: error: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Werror,-Wstrlcpy-strlcat-size]

572 |                         strlcpy((char*)out.body.bytes, attrs1, sizeof(attrs1));
    |                                                                ~~~~~~~^~~~~~~

The warning is correct in that the size is the size of the source, but
that is intended in this case. Use memcpy() instead of strlcpy() to
match the same code in the size_only_race_smaller test above.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Fri, Apr 11, 5:57 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 11, 5:57 PM

jhb requested review of this revision.Fri, Apr 11, 5:57 PM

Harbormaster completed remote builds in B63464: Diff 153535.Fri, Apr 11, 5:57 PM

jhb added a child revision: D49787: bsd.sys.mk: Re-enable warnings for C++11 extensions.Fri, Apr 11, 5:57 PM

I don't know why, but I got the new error after applying the change in D49787 (which makes no sense to me, I would have expected to have seen this error before regardless).

Hmm, I'm getting this on stock main it seems so will push it to fix the build.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Apr 11, 7:17 PM

Closed by commit rGfaae895fec65: fusefs tests: Use memcpy to work around a -Wstrlcpy-strlcast-size warning (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGfaae895fec65: fusefs tests: Use memcpy to work around a -Wstrlcpy-strlcast-size warning.