Page MenuHomeFreeBSD

iwlwififw: remove Intel iwlwifi firmware from src.git
ClosedPublic

Authored by bz on Tue, Apr 8, 5:14 PM.
Tags
None
Referenced Files
F114804398: D49713.diff
Thu, Apr 17, 2:46 AM
Unknown Object (File)
Tue, Apr 15, 1:43 AM
Unknown Object (File)
Mon, Apr 14, 2:45 PM
Unknown Object (File)
Mon, Apr 14, 2:44 PM
Unknown Object (File)
Mon, Apr 14, 2:42 PM
Unknown Object (File)
Mon, Apr 14, 2:41 PM
Unknown Object (File)
Mon, Apr 14, 6:52 AM
Unknown Object (File)
Mon, Apr 14, 6:52 AM

Details

Summary

Following the example of rtw88 and rtw89 only ship iwlwifi firmware
from ports/packages. Users are asked to run fwget(8) to install the
firmware needed for their system or build it from ports
(see also UPDATING).

This is the end of a long story adding wireless support to fwget(8),
migrating the firmware for multiple branches into ports, splitting them
up into flavors, and updating some install media and the installer to
provide firmware.

The overall amount for new firmware amongst all drivers would have
added more than 100M of binary blobs to src.git for the first import,
ignoring future updates which (along with some duplication between
multiple drivers) was considered too much.

While maintenance within the src tree certainly would have been
easier in the longer term this seems to be the better solution and
I would like to thank everyone who helped along the path to get there.

The iwlwififw.4 man page is to stay (for now) and will likely point
at the appropriate firmware package flavor in the future as well.

Sponsored by: The FreeBSD Foundation
Requested by: core (Oct 2022)
MFC after: 3 days

Test Plan

Mostly someone to double-ceck the UPDATING and the
proposed commit message (and ObsoleteFiles.inc).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 63413
Build 60297: arc lint + arc unit

Event Timeline

bz requested review of this revision.Tue, Apr 8, 5:14 PM

Could anyone read the description and the UPDATING lines to make sure they sound correct and have no errors?

The description looks good. There are a couple of spelling mistakes: pakages > packages, fimrware > firmware, maintainance > maintenance, and solutions > solution.

UPDATING
31–34

What you have is fine, but if you want something more formal, here is my suggestion. I also put 'Before updating their system' at the beginning of the sentence to emphasize that the timing is important.

As suggested / pointed out by @jrm:
Fixed typos in the proposed commit message.
Updated the UPDATING text.
Also moved the date to today.

UPDATING
31–34

Doh. The suggested edits did not show up on the top. Let me see..

Reword further based on @jrm 's suggestion with the only difference that
I moved the cause (removal of firmware) to the end.

bz marked an inline comment as done.Wed, Apr 9, 5:19 PM
bz added inline comments.
UPDATING
31–34

Thanks a lot for the changes. I only moved the first sentence to the end. The sentence got a bit long now but ...

This revision is now accepted and ready to land.Thu, Apr 10, 8:18 AM
emaste added inline comments.
UPDATING
33

I suggest reordering the points, i.e.

Intel iwlwifi has been removed from the src repository. Before updating ...

Phabricator did not auto-close this. I added the commits (I hope correctly) to related objects