User Details
- User Since
- Apr 10 2016, 5:00 PM (423 w, 1 h)
Today
@freebsd_ny-central.org, this looks ready to me. Could you rebase your changes on top of the latest main after 3c1326a472ca67ff6159d644589ab5e5bfc1258c? Then we can commit.
We're almost there, but the patch now fails to apply after 1a720cbec513210fa2e85c3882741ef2f6dc5f35. @freebsd_ny-central.org, could you rebase your changes on top of the latest from main?
Thu, May 16
Wed, May 15
Tue, May 14
Mon, May 13
Incorporate suggestion from emaste@.
Tue, May 7
Mon, May 6
Thu, May 2
Wed, May 1
Tue, Apr 30
Also bump PORTREVISION
Mon, Apr 29
The build now looks good to me. I asked a few minor questions below.
The message in periodic.conf is clear.
# Compatibility with old daily variable names. # They can be removed in stable/11. security_daily_compat_var() { local var=$1 dailyvar value
Sun, Apr 28
Committed in b30a7e5418be5c5d27ac967f5ce99461ab79c37c and referenced the original review at https://reviews.freebsd.org/D43940.
Fri, Apr 26
Remove check for wayland flavor; it's no longer necessary with PGTK as a slave option.
Remove leftover comment
- Incorporate jbeich's suggestion to use OPTIONS_SLAVE
Chris, rather than overwrite your review, I rebased your work on top of the latest of the main branch and created new review in https://reviews.freebsd.org/D44977. The commit message is based on your summary in D43940. If everything looks good to you there, I'll commit.
Chris, rather than overwrite your review, I rebased your work on top of the latest of the main branch. The commit message is based on your summary in D43940. If everything looks good to you, I'll commit.
Thu, Apr 25
Adding some IRC discussion here.
Wed, Apr 24
Restore changes after last arc diff --update
Add a few more tweaks mostly related to the change in D44929, which this revision depends on.
Tue, Apr 23
There is still a problem to be resolved. Even though we have OPTION_EXCLUDE=CAIRO... for the Wayland flavor, CAIRO_CONFIGURE_WITH=cairo is still adding --without-cairo to CONFIGURE_ARGS.
Ensure the correct LIB_DEPENDS and USES are specified
Don't change OPTIONS_DEFAULT here. Do it in a subsequent commit.
Mon, Apr 22
Oh, yes. When people do, e.g., pkg info serf, they should see the new maintainer.
Sat, Apr 20
Fri, Apr 19
Looks good to me.
Apr 19 2024
LGTM. I flagged a few other optional nits.
Apr 17 2024
Thanks. Looks good. Could you also run it through something like portlint -AC and portclippy/portfmt?
Apr 16 2024
To elaborate, I felt that specifically checking for the issue at hand is unlikely to introduce any new problems, but adding set -e, which, of course, affects the whole script is more likely. That said, since @michael is prepared to take on any new problems, I'm fine either way.
Apr 15 2024
Apr 14 2024
Apr 13 2024
@michaelo, thanks for sticking with this review. My preference is still to go with the || exit \$? with or without the set -e.
Apr 11 2024
Apr 9 2024
LGTM However, someone from portmgr should approve. I'll try to get someone to look today.
Apr 7 2024
Mar 30 2024
Mar 28 2024
Mar 26 2024
Also, chase editors/emacs update.
Mar 23 2024
Mar 20 2024
Mar 19 2024
Mar 18 2024
I'll commit now and incorporate @pauamma_gundo.com's suggestion.