Page MenuHomeFreeBSD
Differential D49040

tests/netinet: add few tests for sending a broadcast packet
ClosedPublic
Actions

Authored by glebius on Mon, Feb 17, 11:37 PM.
Tags
None
Referenced Files
F110721145: D49040.diff
Sat, Feb 22, 8:05 AM
F110721012: D49040.diff
Sat, Feb 22, 8:03 AM
F110712698: D49040.diff
Sat, Feb 22, 5:22 AM
F110705616: D49040.diff
Sat, Feb 22, 3:03 AM
Unknown Object (File)
Tue, Feb 18, 1:02 AM
Subscribers
asomers
imp
melifaro

Details

Reviewers
markj
Group Reviewers
network
Commits
rGad77d3177f3e: tests/netinet: add few tests for sending a broadcast packet
Summary
  1. Set SO_BROADCAST and send to INADDR_BROADCAST. This one is broken since at least FreeBSD 6.0, see bug 99558. Today it sends packet to a non-broadcast link level address.
  2. Set SO_BROADCAST, set IP_ONESBCAST and send to local broadcast address.
  3. Set SO_BROADCAST and send to local broadcast address.

For each test we bind a second socket to check whether the broadcast
is actually received.

PR: 99558

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62492
Build 59376: arc lint + arc unit

Event Timeline

glebius created this revision.Mon, Feb 17, 11:37 PM
Herald added subscribers: melifaro, asomers, imp. · View Herald TranscriptMon, Feb 17, 11:37 PM
glebius requested review of this revision.Mon, Feb 17, 11:37 PM
glebius added a child revision: D49041: netinet: rename in_broadcast() to in_ifnet_broadcast().
Harbormaster completed remote builds in B62492: Diff 151132.Mon, Feb 17, 11:38 PM
markj accepted this revision as: markj.Tue, Feb 18, 9:27 PM
This revision is now accepted and ready to land.Tue, Feb 18, 9:27 PM
glebius updated this revision to Diff 151271.Thu, Feb 20, 10:08 PM

Make IP_ONESBCAST test more sophisticated: on machines with more interfaces
do more testing.

This revision now requires review to proceed.Thu, Feb 20, 10:08 PM
Harbormaster completed remote builds in B62555: Diff 151271.Thu, Feb 20, 10:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 22, 2:13 AM
Closed by commit rGad77d3177f3e: tests/netinet: add few tests for sending a broadcast packet (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGad77d3177f3e: tests/netinet: add few tests for sending a broadcast packet.

Revision Contents
Changeset List

PathSize
tests/
sys/
netinet/
3 lines
177 lines

Diff 151132

View Options

tests/sys/netinet/Makefile

Loading...
View Options

tests/sys/netinet/broadcast.c

Loading...