Paths

Table of Contentst

Differential D48966

sound: Call chn_kill() in chn_init() failure
ClosedPublic
Actions

Authored by christos on Feb 12 2025, 4:04 PM.

Tags

None

Referenced Files

	F112525244: D48966.id150982.diff
	Wed, Mar 19, 8:17 AM

	Unknown Object (File)
	Thu, Mar 6, 11:59 PM

	Unknown Object (File)
	Sat, Mar 1, 7:20 AM

	Unknown Object (File)
	Wed, Feb 26, 10:40 AM

	Unknown Object (File)
	Wed, Feb 26, 10:40 AM

	Unknown Object (File)
	Wed, Feb 26, 10:40 AM

	Unknown Object (File)
	Wed, Feb 26, 10:40 AM

	Unknown Object (File)
	Wed, Feb 26, 12:35 AM

View All 16 Files

Subscribers

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG858504a1d89f: sound: Call chn_kill() in chn_init() failure
rGbc7e65e95015: sound: Call chn_kill() in chn_init() failure

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62426
Build 59310: arc lint + arc unit

Event Timeline

christos created this revision.Feb 12 2025, 4:04 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2025, 4:04 PM

christos requested review of this revision.Feb 12 2025, 4:04 PM

Harbormaster completed remote builds in B62397: Diff 150911.Feb 12 2025, 4:05 PM

christos added a parent revision: D48962: sound: Update comment and channel insertion in vchan_create().Feb 12 2025, 4:06 PM

christos added inline comments.Feb 12 2025, 4:08 PM

sys/dev/sound/pcm/channel.c
1326	I removed this and moved these increments inside the `switch` at the top of `chn_init()`. This is to avoid inconsistencies since `chn_kill()` decrements these counters.

markj added inline comments.Feb 13 2025, 4:49 PM

sys/dev/sound/pcm/channel.c
1188–1190	The FALLTHROUGH comment has to appear at the end of the case.
1192	This comment doesn't seem very useful?

christos marked 2 inline comments as done.Feb 13 2025, 5:01 PM

christos added inline comments.

sys/dev/sound/pcm/channel.c
1192	This was a leftover I forgot to correct. Thank you.

christos marked an inline comment as done.Feb 13 2025, 5:02 PM

Address Mark's comments.

Harbormaster completed remote builds in B62426: Diff 150982.Feb 13 2025, 5:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Feb 25, 11:49 AM

Closed by commit rGbc7e65e95015: sound: Call chn_kill() in chn_init() failure (authored by christos). · Explain Why

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGbc7e65e95015: sound: Call chn_kill() in chn_init() failure.

christos added a commit: rG858504a1d89f: sound: Call chn_kill() in chn_init() failure.Tue, Mar 4, 3:47 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

50 lines

Diff 150982

sys/dev/sound/pcm/channel.c

Loading...