sound: Cache vchanmode
Needs ReviewPublic
Actions

Authored by christos on Mon, Jan 6, 1:45 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

We already cache vchanrate and vchanformat.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61518
Build 58402: arc lint + arc unit

Event Timeline

christos created this revision.Mon, Jan 6, 1:45 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 6, 1:45 PM

christos requested review of this revision.Mon, Jan 6, 1:45 PM

Harbormaster completed remote builds in B61518: Diff 148811.Mon, Jan 6, 1:45 PM

christos mentioned this in D47918: sound: Simplify vchan_getparentchannel().Mon, Jan 6, 1:45 PM

What takes the place of the now-removed locking though?

christos added a parent revision: D47917: sound: Allocate vchans on-demand.Mon, Jan 6, 1:58 PM

christos added a child revision: D48336: sound: Handle multiple primary channel cases in vchan sysctls.

In D48335#1102258, @emaste wrote:

What takes the place of the now-removed locking though?

As is the case for vchanrate and vchanformat, the PCM "sleepable lock", aka PCM_ACQUIRE().

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

sound.h

4 lines

vchan.c

11 lines

Diff 148811

View Options

sys/dev/sound/pcm/sound.h