Page MenuHomeFreeBSD
Differential D48335

sound: Cache vchanmode
AcceptedPublic
Actions

Authored by christos on Jan 6 2025, 1:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 4, 2:24 AM
Unknown Object (File)
Tue, Jan 21, 10:40 AM
Unknown Object (File)
Wed, Jan 15, 12:49 AM
Unknown Object (File)
Tue, Jan 14, 9:33 PM
Unknown Object (File)
Tue, Jan 14, 9:31 PM
Unknown Object (File)
Tue, Jan 14, 2:43 PM
Unknown Object (File)
Sun, Jan 12, 12:26 PM
Unknown Object (File)
Sat, Jan 11, 7:56 AM
View All 13 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Summary

We already cache vchanrate and vchanformat.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61855
Build 58739: arc lint + arc unit

Event Timeline

christos created this revision.Jan 6 2025, 1:45 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 6 2025, 1:45 PM
christos requested review of this revision.Jan 6 2025, 1:45 PM
Harbormaster completed remote builds in B61518: Diff 148811.Jan 6 2025, 1:45 PM
christos mentioned this in D47918: sound: Simplify vchan_getparentchannel().Jan 6 2025, 1:45 PM
emaste added a comment.Jan 6 2025, 1:54 PM

What takes the place of the now-removed locking though?

christos added a parent revision: D47917: sound: Allocate vchans on-demand.Jan 6 2025, 1:58 PM
christos added a child revision: D48336: sound: Handle multiple primary channel cases in vchan sysctls.
christos added a comment.Jan 6 2025, 2:00 PM
In D48335#1102258, @emaste wrote:

What takes the place of the now-removed locking though?

As is the case for vchanrate and vchanformat, the PCM "sleepable lock", aka PCM_ACQUIRE().

dev_submerge.ch accepted this revision.Thu, Jan 9, 12:02 PM
This revision is now accepted and ready to land.Thu, Jan 9, 12:02 PM
christos updated this revision to Diff 149647.Tue, Jan 21, 10:38 AM

Rebase changes in D48435.

This revision now requires review to proceed.Tue, Jan 21, 10:38 AM
Harbormaster completed remote builds in B61854: Diff 149647.Tue, Jan 21, 10:38 AM
christos updated this revision to Diff 149648.Tue, Jan 21, 10:42 AM

Revert change. This was meant for another commit and I messed up my git commands.

Harbormaster completed remote builds in B61855: Diff 149648.Tue, Jan 21, 10:42 AM
dev_submerge.ch accepted this revision.Sat, Jan 25, 1:44 AM

Reapprove, I already accepted this.

This revision is now accepted and ready to land.Sat, Jan 25, 1:44 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
4 lines
11 lines

Diff 149648

View Options

sys/dev/sound/pcm/sound.h

Loading...
View Options

sys/dev/sound/pcm/vchan.c

Loading...