Page MenuHomeFreeBSD
Differential D48335

sound: Cache vchanmode
ClosedPublic
Actions

Authored by christos on Jan 6 2025, 1:45 PM.
Tags
None
Referenced Files
F114206940: D48335.id148811.diff
Wed, Apr 9, 4:17 AM
Unknown Object (File)
Sat, Apr 5, 11:45 AM
Unknown Object (File)
Wed, Mar 26, 8:27 AM
Unknown Object (File)
Wed, Mar 12, 8:24 PM
Unknown Object (File)
Mar 3 2025, 1:02 PM
Unknown Object (File)
Feb 28 2025, 1:50 PM
Unknown Object (File)
Feb 28 2025, 12:55 PM
Unknown Object (File)
Feb 27 2025, 1:08 AM
View All 35 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG58e17fd3c455: sound: Cache vchanmode
rGb50f53cf872e: sound: Cache vchanmode
Summary

We already cache vchanrate and vchanformat.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Jan 6 2025, 1:45 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 6 2025, 1:45 PM
christos requested review of this revision.Jan 6 2025, 1:45 PM
Harbormaster completed remote builds in B61518: Diff 148811.Jan 6 2025, 1:45 PM
christos mentioned this in D47918: sound: Simplify vchan_getparentchannel().Jan 6 2025, 1:45 PM
emaste added a comment.Jan 6 2025, 1:54 PM

What takes the place of the now-removed locking though?

christos added a parent revision: D47917: sound: Allocate vchans on-demand.Jan 6 2025, 1:58 PM
christos added a child revision: D48336: sound: Handle multiple primary channel cases in vchan sysctls.
christos added a comment.Jan 6 2025, 2:00 PM
In D48335#1102258, @emaste wrote:

What takes the place of the now-removed locking though?

As is the case for vchanrate and vchanformat, the PCM "sleepable lock", aka PCM_ACQUIRE().

dev_submerge.ch accepted this revision.Jan 9 2025, 12:02 PM
This revision is now accepted and ready to land.Jan 9 2025, 12:02 PM
christos updated this revision to Diff 149647.Jan 21 2025, 10:38 AM

Rebase changes in D48435.

This revision now requires review to proceed.Jan 21 2025, 10:38 AM
Harbormaster completed remote builds in B61854: Diff 149647.Jan 21 2025, 10:38 AM
christos updated this revision to Diff 149648.Jan 21 2025, 10:42 AM

Revert change. This was meant for another commit and I messed up my git commands.

Harbormaster completed remote builds in B61855: Diff 149648.Jan 21 2025, 10:42 AM
dev_submerge.ch accepted this revision.Jan 25 2025, 1:44 AM

Reapprove, I already accepted this.

This revision is now accepted and ready to land.Jan 25 2025, 1:44 AM
Closed by commit rGb50f53cf872e: sound: Cache vchanmode (authored by christos). · Explain WhyFeb 25 2025, 11:48 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGb50f53cf872e: sound: Cache vchanmode.
christos added a commit: rG58e17fd3c455: sound: Cache vchanmode.Mar 4 2025, 3:47 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
4 lines
11 lines

Diff 151462

View Options

sys/dev/sound/pcm/sound.h

Loading...
View Options

sys/dev/sound/pcm/vchan.c

Loading...