sound: Update comment and channel insertion in vchan_create()
Needs ReviewPublic
Actions

Authored by christos on Wed, Feb 12, 12:28 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

The comment and rationale behind choosing CHN_INSERT_SORT_DESCEND()
instead of CHN_INSERT_SORT_ASCEND() are no longer relevant as of FILLME
("sound: Allocate vchans on-demand").

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62391
Build 59275: arc lint + arc unit

Event Timeline

christos created this revision.Wed, Feb 12, 12:28 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 12, 12:28 PM

christos requested review of this revision.Wed, Feb 12, 12:28 PM

Harbormaster completed remote builds in B62391: Diff 150897.Wed, Feb 12, 12:28 PM

christos added a parent revision: D47917: sound: Allocate vchans on-demand.Wed, Feb 12, 12:28 PM

christos added a parent revision: D48961: sound: Fix vchanrate and vchanformat.

Typo.

Harbormaster completed remote builds in B62392: Diff 150898.Wed, Feb 12, 12:29 PM

christos added a child revision: D48966: sound: Call chn_kill() in chn_init() failure.Wed, Feb 12, 4:06 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

channel.c

2 lines

vchan.c

7 lines

Diff 150897

View Options

sys/dev/sound/pcm/channel.c