sound: Return if the new speed/format is the same as the current one
AcceptedPublic
Actions

Authored by christos on Dec 9 2024, 10:58 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

This gives us a slight performance boost since we do not have to go
through the driver functions.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61682
Build 58566: arc lint + arc unit

Event Timeline

christos created this revision.Dec 9 2024, 10:58 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 9 2024, 10:58 PM

christos requested review of this revision.Dec 9 2024, 10:58 PM

Harbormaster completed remote builds in B61060: Diff 147758.Dec 9 2024, 10:58 PM

christos added a parent revision: D48011: sound: Get rid of redundant variables in chn_setspeed() and chn_setformat().Dec 9 2024, 10:58 PM

This looks OK.

This revision is now accepted and ready to land.Dec 10 2024, 2:02 AM

dev_submerge.ch accepted this revision.Dec 13 2024, 12:52 AM

christos edited the summary of this revision. (Show Details)Jan 12 2025, 1:08 AM

Do the same for chn_setparam().

This revision now requires review to proceed.Jan 12 2025, 1:08 AM

Harbormaster completed remote builds in B61681: Diff 149145.Jan 12 2025, 1:08 AM

Revert change, bad idea.

Harbormaster completed remote builds in B61682: Diff 149146.Jan 12 2025, 1:17 AM

@dev_submerge.ch @emaste Can you re-accept this patch?

dev_submerge.ch accepted this revision.Sun, Feb 2, 3:56 PM

This revision is now accepted and ready to land.Sun, Feb 2, 3:56 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

channel.c

6 lines

Diff 149146

View Options

sys/dev/sound/pcm/channel.c

sound: Return if the new speed/format is the same as the current oneAcceptedPublicActions