Differential D48931

ctld: Fail for missing or invalid CHAP secrets in UCL config
ClosedPublic
Actions

Authored by jhb on Tue, Feb 11, 1:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 16, 1:08 AM

	Unknown Object (File)
	Wed, Feb 12, 9:22 PM

Subscribers

Details

Reviewers

Commits

rGf42f7bedabb3: ctld: Fail for missing or invalid CHAP secrets in UCL config

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62358
Build 59242: arc lint + arc unit

Event Timeline

jhb created this revision.Tue, Feb 11, 1:20 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Feb 11, 1:20 AM

jhb requested review of this revision.Tue, Feb 11, 1:20 AM

Harbormaster completed remote builds in B62358: Diff 150820.Tue, Feb 11, 1:20 AM

jhb added a parent revision: D48930: ctld: Fix the isns-period and isns-timeout keywords in the UCL parser.Tue, Feb 11, 1:20 AM

jhb added a child revision: D48932: ctld: Use preferred style for evaluating result of strcmp.

asomers requested changes to this revision.Tue, Feb 11, 6:23 PM

asomers added inline comments.

usr.sbin/ctld/uclparse.c
74	If this error is going to be fatal, then I suggest you increase the priority of the log message.

This revision now requires changes to proceed.Tue, Feb 11, 6:23 PM

jhb added inline comments.Tue, Feb 11, 7:19 PM

usr.sbin/ctld/uclparse.c
74	The warn vs err is not a severity. log_warnx() is like warnx() in that it just warns, log_errx() is like errx() in that the process exits after logging the warning. In general we don't want to exit for any parse errors.

Ahh, sorry for the noise.

This revision is now accepted and ready to land.Tue, Feb 11, 9:31 PM

Closed by commit rGf42f7bedabb3: ctld: Fail for missing or invalid CHAP secrets in UCL config (authored by jhb). · Explain WhyWed, Feb 12, 7:35 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf42f7bedabb3: ctld: Fail for missing or invalid CHAP secrets in UCL config.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

1 line

Diff 150820

usr.sbin/ctld/uclparse.c

Loading...