Differential D48931

ctld: Fail for missing or invalid CHAP secrets in UCL config
ClosedPublic
Actions

Authored by jhb on Feb 11 2025, 1:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 8, 12:54 PM

	Unknown Object (File)
	Tue, Mar 25, 9:42 PM

	Unknown Object (File)
	Mar 19 2025, 11:50 PM

	Unknown Object (File)
	Mar 13 2025, 12:10 PM

	Unknown Object (File)
	Mar 9 2025, 10:10 AM

	Unknown Object (File)
	Mar 1 2025, 7:58 AM

	Unknown Object (File)
	Feb 21 2025, 3:55 PM

	Unknown Object (File)
	Feb 16 2025, 1:08 AM

View All 9 Files

Subscribers

Details

Reviewers

Commits

rGf42f7bedabb3: ctld: Fail for missing or invalid CHAP secrets in UCL config

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 11 2025, 1:20 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2025, 1:20 AM

jhb requested review of this revision.Feb 11 2025, 1:20 AM

Harbormaster completed remote builds in B62358: Diff 150820.Feb 11 2025, 1:20 AM

jhb added a parent revision: D48930: ctld: Fix the isns-period and isns-timeout keywords in the UCL parser.Feb 11 2025, 1:20 AM

jhb added a child revision: D48932: ctld: Use preferred style for evaluating result of strcmp.

asomers requested changes to this revision.Feb 11 2025, 6:23 PM

asomers added inline comments.

usr.sbin/ctld/uclparse.c
74	If this error is going to be fatal, then I suggest you increase the priority of the log message.

This revision now requires changes to proceed.Feb 11 2025, 6:23 PM

jhb added inline comments.Feb 11 2025, 7:19 PM

usr.sbin/ctld/uclparse.c
74	The warn vs err is not a severity. log_warnx() is like warnx() in that it just warns, log_errx() is like errx() in that the process exits after logging the warning. In general we don't want to exit for any parse errors.

Ahh, sorry for the noise.

This revision is now accepted and ready to land.Feb 11 2025, 9:31 PM

Closed by commit rGf42f7bedabb3: ctld: Fail for missing or invalid CHAP secrets in UCL config (authored by jhb). · Explain WhyFeb 12 2025, 7:35 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf42f7bedabb3: ctld: Fail for missing or invalid CHAP secrets in UCL config.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

1 line

Diff 150923

usr.sbin/ctld/uclparse.c

Loading...