vm_phys_early_alloc(): Switch order of arguments
Needs ReviewPublic
Actions

Authored by olce on Thu, Jan 23, 5:16 PM.

Details

Reviewers

markj
dougm
alc

Summary

It seems more intuitive to specify the requested size first.
Additionally, this will improve consistency with the next commit
introducing vm_phys_early_alloc_ex().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61933
Build 58817: arc lint + arc unit

Event Timeline

olce created this revision.Thu, Jan 23, 5:16 PM

Herald added subscribers: jhibbits, imp. · View Herald TranscriptThu, Jan 23, 5:16 PM

olce requested review of this revision.Thu, Jan 23, 5:16 PM

Harbormaster completed remote builds in B61933: Diff 149790.Thu, Jan 23, 5:16 PM

olce added a parent revision: D48633: vm_phys_early_alloc(): Add diagnostics and comments.Thu, Jan 23, 5:21 PM

olce added a child revision: D48635: vm_phys: Introduce vm_phys_early_alloc_ex*().

It seems more intuitive to specify the requested size first.

I don't really see why. The current interface is consistent with other NUMA-aware allocators, e.g., kmem_malloc_domain(), vm_page_alloc_contig_domain(), vm_phys_alloc_pages().