vm_phys_avail_check(): Check index parity, fix panic messages
ClosedPublic
Actions

Authored by olce on Jan 23 2025, 5:15 PM.

Details

Reviewers

markj
dougm
alc

Commits

rG125ef4e041fe: vm_phys_avail_check(): Check index parity, fix panic messages

Summary

The passed index must be the start of a chunk in phys_avail[], so must
be even. Test for that and print a separate panic message.

While here, fix panic messages: In one, the wrong chunk boundary was
printed, and in another, the desired but not the actual condition was
printed, possibly leading to confusion.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Jan 23 2025, 5:15 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2025, 5:15 PM

olce requested review of this revision.Jan 23 2025, 5:15 PM

Harbormaster completed remote builds in B61925: Diff 149782.Jan 23 2025, 5:15 PM

olce added a child revision: D48627: vm_phys_add_seg(): Check for bad segments, allow empty ones.Jan 23 2025, 5:21 PM

markj accepted this revision.Jan 24 2025, 2:39 PM

This revision is now accepted and ready to land.Jan 24 2025, 2:39 PM

Closed by commit rG125ef4e041fe: vm_phys_avail_check(): Check index parity, fix panic messages (authored by olce). · Explain WhyFeb 19 2025, 2:14 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rG125ef4e041fe: vm_phys_avail_check(): Check index parity, fix panic messages.

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_phys.c

10 lines

Diff 151179

View Options

vm_phys_avail_check(): Check index parity, fix panic messagesClosedPublicActions