Page MenuHomeFreeBSD

net80211: migrate ieee80211_rate2media() to use ieee80211_node_txrate
ClosedPublic

Authored by adrian on Jan 23 2025, 2:45 AM.
Referenced Files
F115668180: D48615.diff
Sat, Apr 26, 8:36 PM
Unknown Object (File)
Fri, Apr 25, 8:08 PM
Unknown Object (File)
Mon, Apr 14, 9:29 AM
Unknown Object (File)
Sat, Apr 5, 12:00 AM
Unknown Object (File)
Mon, Mar 31, 4:49 PM
Unknown Object (File)
Mon, Mar 31, 4:49 PM
Unknown Object (File)
Mar 26 2025, 1:58 PM
Unknown Object (File)
Mar 25 2025, 6:56 PM

Details

Summary

This is one of the two obvious left-over dot11rate lookups that trigger
a debug print. (The other is get_sta_info()).

  • Change ieee80211_rate2media() to use the passed in ieee80211_node_txrate and use the rate type field to see if it's legacy/ht or vht.
  • .. and (I hope!) actually handle the VHT rate correctly.
  • Change the callers of ieee80211_rate2media() to use the new static initialisers.

For the one spot in ieee80211_ht.c which uses the HT initialiser, it should
just be a straight up mechanical change that correctly sets the HT MCS
rate.

For the rest of them in ieee80211.c, they're doing table initialisation
for the media types / rates, and it's currently very focused on legacy
rates. So just leave that all as-is for now with a mechanical change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61968
Build 58852: arc lint + arc unit

Event Timeline

thj added a subscriber: thj.
thj added inline comments.
sys/net80211/ieee80211.c
2736

Don't add the extra newline when this lands

This revision is now accepted and ready to land.Jan 28 2025, 10:09 AM
This revision now requires review to proceed.Jan 30 2025, 5:16 AM
bz requested changes to this revision.Feb 22 2025, 11:22 AM
bz added a subscriber: bz.
bz added inline comments.
sys/net80211/ieee80211.c
2540

int m, rate;

2578

Variable declaration above.

This revision now requires changes to proceed.Feb 22 2025, 11:22 AM

updated, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2025, 7:32 PM
This revision was automatically updated to reflect the committed changes.