Differential D48605

net80211: add ieee80211_node_get_txrate() to populate the "new" transmit struct
Needs ReviewPublic
Actions

Authored by adrian on Thu, Jan 23, 2:36 AM.

Tags

Referenced Files

	F109269476: D48605.id149845.diff
	Sun, Feb 2, 8:31 PM

	F109266193: D48605.id149748.diff
	Sun, Feb 2, 7:33 PM

	F109265572: D48605.id150001.diff
	Sun, Feb 2, 7:20 PM

	F109237426: D48605.id149734.diff
	Sun, Feb 2, 11:08 AM

	F109235928: D48605.id150147.diff
	Sun, Feb 2, 10:40 AM

	F109226608: D48605.id150162.diff
	Sun, Feb 2, 7:45 AM

	F109220493: D48605.id.diff
	Sun, Feb 2, 5:50 AM

	Unknown Object (File)
	Fri, Jan 31, 7:47 PM

View All 9 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Summary

ieee80211_node_get_txrate() populates the passed-in ieee80211_node_txrate with
the current rate configuration.

This is a no-op - nothing is yet setting VHT rates.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61896
Build 58780: arc lint + arc unit

Event Timeline

adrian created this revision.Thu, Jan 23, 2:36 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptThu, Jan 23, 2:36 AM

adrian requested review of this revision.Thu, Jan 23, 2:36 AM

Harbormaster completed remote builds in B61896: Diff 149734.Thu, Jan 23, 2:36 AM

adrian added a parent revision: D48604: net80211: convert ni_txrate to a struct, with extra rate information.Thu, Jan 23, 2:36 AM

adrian added a child revision: D48606: rtwn: move to using ieee80211_node_get_txrate().

adrian added a reviewer: wireless.Thu, Jan 23, 3:03 AM

adrian added a project: wireless.

simplify / type-safe

Harbormaster completed remote builds in B61910: Diff 149748.Thu, Jan 23, 3:10 AM

rebase

Harbormaster completed remote builds in B61956: Diff 149845.Fri, Jan 24, 1:51 AM

rebase

Harbormaster completed remote builds in B61983: Diff 149897.Fri, Jan 24, 3:31 PM

rebase, address changes

Harbormaster completed remote builds in B62049: Diff 150001.Mon, Jan 27, 12:16 AM

bz added a subscriber: bz.Wed, Jan 29, 12:55 AM

bz added inline comments.

sys/net80211/ieee80211_node.c
3187	I love KASSERTs or MPASS to check passed in pointers to not be NULL. Just happens once too often net80211 still and ni is prone to it ... Also no new line needed if there is no declaration.
sys/net80211/ieee80211_node.h
519	This indent looks wrong at least in Phabricator.

update, add TXRATE_HT

Harbormaster completed remote builds in B62112: Diff 150147.Thu, Jan 30, 5:15 AM

update, add TXRATE_HT

Harbormaster completed remote builds in B62127: Diff 150162.Thu, Jan 30, 5:15 AM

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_node.h

2 lines

ieee80211_node.c

18 lines

Diff 149734

sys/net80211/ieee80211_node.h

Loading...

sys/net80211/ieee80211_node.c

Loading...